aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarek Polacek <polacek@redhat.com>2015-09-07 09:19:13 +0000
committerMarek Polacek <mpolacek@gcc.gnu.org>2015-09-07 09:19:13 +0000
commit8f1e28e0ff4a93f1416f62c6f82ed62174a02e7d (patch)
treea0d4d055dc71292901ea556ac5ab23acc66e16e7
parent85bc8baac9a16ba74116be18b577b840fcaa499d (diff)
downloadgcc-8f1e28e0ff4a93f1416f62c6f82ed62174a02e7d.zip
gcc-8f1e28e0ff4a93f1416f62c6f82ed62174a02e7d.tar.gz
gcc-8f1e28e0ff4a93f1416f62c6f82ed62174a02e7d.tar.bz2
re PR inline-asm/67448 (compiler crash#inline assembly#rvalue operand with constraint "m")
PR inline-asm/67448 * gimplify.c (gimplify_asm_expr): Don't allow MODIFY_EXPR as a memory input. * gcc.dg/asm-10.c: New test. From-SVN: r227517
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/gimplify.c3
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.dg/asm-10.c12
4 files changed, 25 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index e64180a..d5f9f78 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,11 @@
2015-09-07 Marek Polacek <polacek@redhat.com>
+ PR inline-asm/67448
+ * gimplify.c (gimplify_asm_expr): Don't allow MODIFY_EXPR as
+ a memory input.
+
+2015-09-07 Marek Polacek <polacek@redhat.com>
+
* system.h (INTTYPE_MINIMUM): Rewrite to avoid shift warning.
2015-09-04 Paolo Bonzini <bonzini@gnu.org>
diff --git a/gcc/gimplify.c b/gcc/gimplify.c
index c8f2718..b7a918b 100644
--- a/gcc/gimplify.c
+++ b/gcc/gimplify.c
@@ -5210,7 +5210,8 @@ gimplify_asm_expr (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p)
if (TREE_CODE (inputv) == PREDECREMENT_EXPR
|| TREE_CODE (inputv) == PREINCREMENT_EXPR
|| TREE_CODE (inputv) == POSTDECREMENT_EXPR
- || TREE_CODE (inputv) == POSTINCREMENT_EXPR)
+ || TREE_CODE (inputv) == POSTINCREMENT_EXPR
+ || TREE_CODE (inputv) == MODIFY_EXPR)
TREE_VALUE (link) = error_mark_node;
tret = gimplify_expr (&TREE_VALUE (link), pre_p, post_p,
is_gimple_lvalue, fb_lvalue | fb_mayfail);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index fdec965..5fece2f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-09-07 Marek Polacek <polacek@redhat.com>
+
+ PR inline-asm/67448
+ * gcc.dg/asm-10.c: New test.
+
2015-09-04 Jakub Jelinek <jakub@redhat.com>
PR middle-end/67452
diff --git a/gcc/testsuite/gcc.dg/asm-10.c b/gcc/testsuite/gcc.dg/asm-10.c
new file mode 100644
index 0000000..e6c03c6
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/asm-10.c
@@ -0,0 +1,12 @@
+/* PR inline-asm/67448 */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+void
+f (int i)
+{
+ asm ("" : : "m"(i += 1)); /* { dg-error "not directly addressable" } */
+ asm ("" : : "m"(i++)); /* { dg-error "not directly addressable" } */
+ asm ("" : : "m"(++i)); /* { dg-error "not directly addressable" } */
+ asm ("" : : "m"(i = 0)); /* { dg-error "not directly addressable" } */
+}