diff options
| author | Martin Liska <mliska@suse.cz> | 2019-03-07 16:33:52 +0100 |
|---|---|---|
| committer | Martin Liska <marxin@gcc.gnu.org> | 2019-03-07 15:33:52 +0000 |
| commit | 606711a1671cc63713b893c4557df967a5a6ac20 (patch) | |
| tree | fd2183289f3e715a297915d890a8581a5d771fa4 | |
| parent | 7c3f98ca6567d5b12d28421a4a3deec3b9c52efc (diff) | |
| download | gcc-606711a1671cc63713b893c4557df967a5a6ac20.zip gcc-606711a1671cc63713b893c4557df967a5a6ac20.tar.gz gcc-606711a1671cc63713b893c4557df967a5a6ac20.tar.bz2 | |
Significantly speed up verifiers for a cgraph_node with many clones.
2019-03-07 Martin Liska <mliska@suse.cz>
* cgraph.c (cgraph_node::verify_node): Verify with a neighbour
which is equivalent to searching for this in clones chain.
* symtab.c (symtab_node::verify_base): Similarly compare ASM
names with a neighbour and special case first node in a chain.
From-SVN: r269461
| -rw-r--r-- | gcc/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/cgraph.c | 14 | ||||
| -rw-r--r-- | gcc/symtab.c | 39 |
3 files changed, 37 insertions, 23 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 507c8e1..e62b5e5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2019-03-07 Martin Liska <mliska@suse.cz> + + * cgraph.c (cgraph_node::verify_node): Verify with a neighbour + which is equivalent to searching for this in clones chain. + * symtab.c (symtab_node::verify_base): Similarly compare ASM + names with a neighbour and special case first node in a chain. + 2019-01-25 Jason Merrill <jason@redhat.com> PR c++/80916 - spurious "static but not defined" warning. diff --git a/gcc/cgraph.c b/gcc/cgraph.c index de82316..dfe1833 100644 --- a/gcc/cgraph.c +++ b/gcc/cgraph.c @@ -3240,14 +3240,14 @@ cgraph_node::verify_node (void) if (clone_of) { - cgraph_node *n; - for (n = clone_of->clones; n; n = n->next_sibling_clone) - if (n == this) - break; - if (!n) + cgraph_node *first_clone = clone_of->clones; + if (first_clone != this) { - error ("cgraph_node has wrong clone_of"); - error_found = true; + if (prev_sibling_clone->clone_of != clone_of) + { + error ("cgraph_node has wrong clone_of"); + error_found = true; + } } } if (clones) diff --git a/gcc/symtab.c b/gcc/symtab.c index c9fa16b..16a2135 100644 --- a/gcc/symtab.c +++ b/gcc/symtab.c @@ -1040,23 +1040,30 @@ symtab_node::verify_base (void) if (symtab->assembler_name_hash) { hashed_node = symtab_node::get_for_asmname (DECL_ASSEMBLER_NAME (decl)); - if (hashed_node && hashed_node->previous_sharing_asm_name) + if (hashed_node) { - error ("assembler name hash list corrupted"); - error_found = true; - } - while (hashed_node) - { - if (hashed_node == this) - break; - hashed_node = hashed_node->next_sharing_asm_name; - } - if (!hashed_node - && !(is_a <varpool_node *> (this) - && DECL_HARD_REGISTER (decl))) - { - error ("node not found in symtab assembler name hash"); - error_found = true; + if (hashed_node->previous_sharing_asm_name) + { + error ("assembler name hash list corrupted"); + error_found = true; + } + else if (previous_sharing_asm_name == NULL) + { + if (hashed_node != this) + { + error ("assembler name hash list corrupted"); + error_found = true; + } + } + else if (!(is_a <varpool_node *> (this) && DECL_HARD_REGISTER (decl))) + { + if (!asmname_hasher::equal (previous_sharing_asm_name, + DECL_ASSEMBLER_NAME (decl))) + { + error ("node not found in symtab assembler name hash"); + error_found = true; + } + } } } if (previous_sharing_asm_name |