diff options
author | Jonathan Wakely <jwakely@redhat.com> | 2021-06-01 14:22:38 +0100 |
---|---|---|
committer | Jonathan Wakely <jwakely@redhat.com> | 2021-10-01 20:36:54 +0100 |
commit | 20751fad19e1b0fb4272309dd6d7fde182b08dc1 (patch) | |
tree | cbe1bbfff08be6921a7226b1a48e8fa6c22484c5 | |
parent | 9b790acc2207d69b4ebc0f4addd34a0aa32ec6cf (diff) | |
download | gcc-20751fad19e1b0fb4272309dd6d7fde182b08dc1.zip gcc-20751fad19e1b0fb4272309dd6d7fde182b08dc1.tar.gz gcc-20751fad19e1b0fb4272309dd6d7fde182b08dc1.tar.bz2 |
libstdc++: Implement LWG 3392 for std::ranges::distance
libstdc++-v3/ChangeLog:
* include/bits/ranges_base.h (ranges::distance): Split overload
into two (LWG 3392).
* testsuite/24_iterators/range_operations/lwg3392.cc: New test.
-rw-r--r-- | libstdc++-v3/include/bits/ranges_base.h | 27 | ||||
-rw-r--r-- | libstdc++-v3/testsuite/24_iterators/range_operations/lwg3392.cc | 30 |
2 files changed, 45 insertions, 12 deletions
diff --git a/libstdc++-v3/include/bits/ranges_base.h b/libstdc++-v3/include/bits/ranges_base.h index d6166ab..01d0c35 100644 --- a/libstdc++-v3/include/bits/ranges_base.h +++ b/libstdc++-v3/include/bits/ranges_base.h @@ -787,22 +787,25 @@ namespace ranges struct __distance_fn final { template<input_or_output_iterator _It, sentinel_for<_It> _Sent> - [[nodiscard]] + requires (!sized_sentinel_for<_Sent, _It>) constexpr iter_difference_t<_It> - operator()(_It __first, _Sent __last) const + operator()[[nodiscard]](_It __first, _Sent __last) const { - if constexpr (sized_sentinel_for<_Sent, _It>) - return __last - __first; - else + iter_difference_t<_It> __n = 0; + while (__first != __last) { - iter_difference_t<_It> __n = 0; - while (__first != __last) - { - ++__first; - ++__n; - } - return __n; + ++__first; + ++__n; } + return __n; + } + + template<input_or_output_iterator _It, sized_sentinel_for<_It> _Sent> + [[nodiscard]] + constexpr iter_difference_t<_It> + operator()(const _It& __first, const _Sent& __last) const + { + return __last - __first; } template<range _Range> diff --git a/libstdc++-v3/testsuite/24_iterators/range_operations/lwg3392.cc b/libstdc++-v3/testsuite/24_iterators/range_operations/lwg3392.cc new file mode 100644 index 0000000..3278035 --- /dev/null +++ b/libstdc++-v3/testsuite/24_iterators/range_operations/lwg3392.cc @@ -0,0 +1,30 @@ +// { dg-options "-std=gnu++20" } +// { dg-do compile { target c++20 } } + +#include <iterator> + +struct movable_iterator +{ + using difference_type = long; + + movable_iterator() = default; + movable_iterator(movable_iterator&&) = default; + movable_iterator& operator=(movable_iterator&&) = default; + + int operator*() const { return 1; } + + movable_iterator& operator++() { return *this; } + void operator++(int) { } + + bool operator==(const movable_iterator&) const = default; +}; + +using namespace std; + +constexpr counted_iterator<movable_iterator> it({}, 3); + +static_assert( sized_sentinel_for<std::default_sentinel_t, counted_iterator<movable_iterator>> ); +// LWG 3392 +// ranges::distance() cannot be used on a move-only iterator +// with a sized sentinel +static_assert( ranges::distance(it, default_sentinel) == 3 ); |