diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2016-02-19 17:01:50 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2016-02-19 17:01:50 +0100 |
| commit | 19e2158623cf45a9c9ea731957bea6c3de4a4e56 (patch) | |
| tree | e5a018c85eb5153fd7dee63c69b092e027fefa0c | |
| parent | 2db16594fe8bebd0ea784d4b3004a8f0c1af7869 (diff) | |
| download | gcc-19e2158623cf45a9c9ea731957bea6c3de4a4e56.zip gcc-19e2158623cf45a9c9ea731957bea6c3de4a4e56.tar.gz gcc-19e2158623cf45a9c9ea731957bea6c3de4a4e56.tar.bz2 | |
re PR c++/67767 (-Wsuggest-attribute=noreturn suggests noreturn for function which already has noreturn and cold.)
PR c++/67767
* parser.c (cp_parser_std_attribute_spec_seq): Don't assume
attr_spec is always single element chain, chain all the attributes
properly together in the right order.
* g++.dg/cpp0x/pr67767.C: New test.
From-SVN: r233560
| -rw-r--r-- | gcc/cp/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/cp/parser.c | 11 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/cpp0x/pr67767.C | 10 |
4 files changed, 29 insertions, 4 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 96150be..12a3967 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,10 @@ +2016-02-19 Jakub Jelinek <jakub@redhat.com> + + PR c++/67767 + * parser.c (cp_parser_std_attribute_spec_seq): Don't assume + attr_spec is always single element chain, chain all the attributes + properly together in the right order. + 2016-02-18 Jason Merrill <jason@redhat.com> * mangle.c (maybe_check_abi_tags): Add for_decl parm. Call diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 18f3902..53decdc 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -24104,7 +24104,8 @@ cp_parser_std_attribute_spec (cp_parser *parser) static tree cp_parser_std_attribute_spec_seq (cp_parser *parser) { - tree attr_specs = NULL; + tree attr_specs = NULL_TREE; + tree attr_last = NULL_TREE; while (true) { @@ -24114,11 +24115,13 @@ cp_parser_std_attribute_spec_seq (cp_parser *parser) if (attr_spec == error_mark_node) return error_mark_node; - TREE_CHAIN (attr_spec) = attr_specs; - attr_specs = attr_spec; + if (attr_last) + TREE_CHAIN (attr_last) = attr_spec; + else + attr_specs = attr_last = attr_spec; + attr_last = tree_last (attr_last); } - attr_specs = nreverse (attr_specs); return attr_specs; } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 604bb3c..f916c9c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-02-19 Jakub Jelinek <jakub@redhat.com> + + PR c++/67767 + * g++.dg/cpp0x/pr67767.C: New test. + 2016-02-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com> * lib/target-supports.exp: Define aarch64_asm_FUNC_ok checks diff --git a/gcc/testsuite/g++.dg/cpp0x/pr67767.C b/gcc/testsuite/g++.dg/cpp0x/pr67767.C new file mode 100644 index 0000000..fd4ae2d --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/pr67767.C @@ -0,0 +1,10 @@ +// PR c++/67767 +// { dg-do compile { target c++11 } } +// { dg-options "-Wsuggest-attribute=noreturn" } + +void foo [[gnu::cold, gnu::noreturn]] (); + +void foo () // { dg-bogus "function might be candidate for attribute" } +{ + throw 1; +} |