diff options
| author | Eric Botcazou <ebotcazou@adacore.com> | 2019-07-22 13:56:50 +0000 |
|---|---|---|
| committer | Pierre-Marie de Rodat <pmderodat@gcc.gnu.org> | 2019-07-22 13:56:50 +0000 |
| commit | f3d2fbfdb83bcc60d72824daf7a470c0e5398854 (patch) | |
| tree | ced0090a1981e3808c919aa6723cdb5351d1a48c | |
| parent | 1a79e03b8012d5094e5bd432df59abeca5c2fe18 (diff) | |
| download | gcc-f3d2fbfdb83bcc60d72824daf7a470c0e5398854.zip gcc-f3d2fbfdb83bcc60d72824daf7a470c0e5398854.tar.gz gcc-f3d2fbfdb83bcc60d72824daf7a470c0e5398854.tar.bz2 | |
[Ada] Fix spurious loop warning for function with Out parameter
The compiler gives a spurious warning about a possible infinite while
loop whose condition contains a call to a function that takes an Out or
In/Out parameter and whose actual is a variable that is not modified in
the loop, because it still thinks that functions can only have In
parameters.
2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_warn.adb (Find_Var): Bail out for a function call with an
Out or In/Out parameter.
gcc/testsuite/
* gnat.dg/warn23.adb: New testcase.
From-SVN: r273673
| -rw-r--r-- | gcc/ada/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/ada/sem_warn.adb | 5 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gnat.dg/warn23.adb | 17 |
4 files changed, 31 insertions, 0 deletions
diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index ec1b81a..6fc9d1c 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -1,3 +1,8 @@ +2019-07-22 Eric Botcazou <ebotcazou@adacore.com> + + * sem_warn.adb (Find_Var): Bail out for a function call with an + Out or In/Out parameter. + 2019-07-22 Nicolas Roche <roche@adacore.com> * terminals.c (__gnat_tty_waitpid): Support both blocking and diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb index 16a772a..0e1e292 100644 --- a/gcc/ada/sem_warn.adb +++ b/gcc/ada/sem_warn.adb @@ -333,6 +333,11 @@ package body Sem_Warn is elsif Has_Warnings_Off (Entity (Name (N))) then return; + + -- Forget it if the parameter is not In + + elsif Has_Out_Or_In_Out_Parameter (Entity (Name (N))) then + return; end if; -- OK, see if we have one argument diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 2fa30eb..c542c62 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-07-22 Eric Botcazou <ebotcazou@adacore.com> + + * gnat.dg/warn23.adb: New testcase. + 2019-07-22 Javier Miranda <miranda@adacore.com> * gnat.dg/cpp_constructor2.adb: New testcase. diff --git a/gcc/testsuite/gnat.dg/warn23.adb b/gcc/testsuite/gnat.dg/warn23.adb new file mode 100644 index 0000000..63d0557 --- /dev/null +++ b/gcc/testsuite/gnat.dg/warn23.adb @@ -0,0 +1,17 @@ +-- { dg-do compile } + +procedure Warn23 is + + type Enum_Type is (A, B, C); + + function Poll (E : out Enum_Type) return Boolean + with Convention => Ada, + Import => True; + + E : Enum_Type; + +begin + while Poll (E) loop + null; + end loop; +end; |