diff options
| author | Richard Biener <rguenther@suse.de> | 2013-04-04 10:55:25 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2013-04-04 10:55:25 +0000 |
| commit | f1bf4f3afb21fdb807c050693ac9da523e64f2a4 (patch) | |
| tree | 4de685c6f239c04550d50264c0cd2569faa2cb2c | |
| parent | 2d50082803f9338b666998cf15f50d6f2d43284d (diff) | |
| download | gcc-f1bf4f3afb21fdb807c050693ac9da523e64f2a4.zip gcc-f1bf4f3afb21fdb807c050693ac9da523e64f2a4.tar.gz gcc-f1bf4f3afb21fdb807c050693ac9da523e64f2a4.tar.bz2 | |
re PR tree-optimization/56837 (-ftree-loop-distribute-patterns generates incorrect code)
2013-04-04 Richard Biener <rguenther@suse.de>
PR tree-optimization/56837
* tree-loop-distribution.c (classify_partition): For non-zero
values require that the value has the same precision as its
mode to be useful as memset value.
* g++.dg/torture/pr56837.C: New testcase.
From-SVN: r197476
| -rw-r--r-- | gcc/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/torture/pr56837.C | 20 | ||||
| -rw-r--r-- | gcc/tree-loop-distribution.c | 12 |
4 files changed, 40 insertions, 4 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 26e7f08..8c28100 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2013-04-04 Richard Biener <rguenther@suse.de> + + PR tree-optimization/56837 + * tree-loop-distribution.c (classify_partition): For non-zero + values require that the value has the same precision as its + mode to be useful as memset value. + 2013-04-03 Nick Clifton <nickc@redhat.com> * config/v850/v850e3v5.md (fmasf4): Use fmaf.s on E3V5 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 6596dce..a8ecc41 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-04-04 Richard Biener <rguenther@suse.de> + + PR tree-optimization/56837 + * g++.dg/torture/pr56837.C: New testcase. + 2013-04-04 Tobias Burnus <burnus@net-b.de> PR fortran/50269 diff --git a/gcc/testsuite/g++.dg/torture/pr56837.C b/gcc/testsuite/g++.dg/torture/pr56837.C new file mode 100644 index 0000000..d007122 --- /dev/null +++ b/gcc/testsuite/g++.dg/torture/pr56837.C @@ -0,0 +1,20 @@ +// { dg-do run } +// { dg-options "-ftree-loop-distribute-patterns" } + +extern "C" void abort (void); +extern "C" int memcmp (const void *, const void *, __SIZE_TYPE__); + +bool b1[8]; +bool b2[8] = { true, true, true, true, true, true, true, true }; + +int main() +{ + unsigned int i; + for(i=0 ; i < 8; i++) + b1[i] = true; + + if (memcmp (b1, b2, 8) != 0) + abort (); + + return 0; +} diff --git a/gcc/tree-loop-distribution.c b/gcc/tree-loop-distribution.c index 70f71b3..101efbe 100644 --- a/gcc/tree-loop-distribution.c +++ b/gcc/tree-loop-distribution.c @@ -942,13 +942,17 @@ classify_partition (loop_p loop, struct graph *rdg, partition_t partition) gimple stmt = DR_STMT (single_store); tree rhs = gimple_assign_rhs1 (stmt); if (!(integer_zerop (rhs) - || integer_all_onesp (rhs) || real_zerop (rhs) || (TREE_CODE (rhs) == CONSTRUCTOR && !TREE_CLOBBER_P (rhs)) - || (INTEGRAL_TYPE_P (TREE_TYPE (rhs)) - && (TYPE_MODE (TREE_TYPE (gimple_assign_lhs (stmt))) - == TYPE_MODE (unsigned_char_type_node))))) + || ((integer_all_onesp (rhs) + || (INTEGRAL_TYPE_P (TREE_TYPE (rhs)) + && (TYPE_MODE (TREE_TYPE (rhs)) + == TYPE_MODE (unsigned_char_type_node)))) + /* For stores of a non-zero value require that the precision + of the value matches its actual size. */ + && (TYPE_PRECISION (TREE_TYPE (rhs)) + == GET_MODE_BITSIZE (TYPE_MODE (TREE_TYPE (rhs))))))) return; if (TREE_CODE (rhs) == SSA_NAME && !SSA_NAME_IS_DEFAULT_DEF (rhs) |