diff options
| author | Kito Cheng <kito.cheng@sifive.com> | 2023-11-14 11:17:45 +0800 |
|---|---|---|
| committer | Kito Cheng <kito.cheng@sifive.com> | 2023-11-16 19:36:23 +0800 |
| commit | defa8681d951c6d6c43c71e3636ce4db9de04a28 (patch) | |
| tree | 4eba57c356cd8e2b414541f1859a525e73814a23 | |
| parent | e36d5f424a0dcb984620a172c73da989f215dc42 (diff) | |
| download | gcc-defa8681d951c6d6c43c71e3636ce4db9de04a28.zip gcc-defa8681d951c6d6c43c71e3636ce4db9de04a28.tar.gz gcc-defa8681d951c6d6c43c71e3636ce4db9de04a28.tar.bz2 | |
RISC-V: Save/restore ra register correctly [PR112478]
We set ra to fixed register now, but we still need to save/restore that at
prologue/epilogue if that has used.
gcc/ChangeLog:
PR target/112478
* config/riscv/riscv.cc (riscv_save_return_addr_reg_p): Check ra
is ever lived.
gcc/testsuite/ChangeLog:
PR target/112478
* gcc.target/riscv/pr112478.c: New.
Reviewed-by: Christoph Müllner <christoph.muellner@vrull.eu>
Tested-by: Christoph Müllner <christoph.muellner@vrull.eu>
| -rw-r--r-- | gcc/config/riscv/riscv.cc | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/riscv/pr112478.c | 8 |
2 files changed, 12 insertions, 0 deletions
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index e466d4f..aada6ac 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -5825,6 +5825,10 @@ riscv_save_return_addr_reg_p (void) if (riscv_far_jump_used_p ()) return true; + /* We need to save it if anyone has used that. */ + if (df_regs_ever_live_p (RETURN_ADDR_REGNUM)) + return true; + /* Need not to use ra for leaf when frame pointer is turned off by option whatever the omit-leaf-frame's value. */ if (frame_pointer_needed && crtl->is_leaf diff --git a/gcc/testsuite/gcc.target/riscv/pr112478.c b/gcc/testsuite/gcc.target/riscv/pr112478.c new file mode 100644 index 0000000..0bbde20 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/pr112478.c @@ -0,0 +1,8 @@ +/* { dg-do compile } */ +/* { dg-options "-ffat-lto-objects" } */ + +void foo() { + asm volatile("# " : ::"ra"); +} + +/* { dg-final { scan-assembler "s(w|d)\[ \t\]*ra" } } */ |