diff options
| author | Jeff Law <law@redhat.com> | 2015-09-21 11:09:53 -0600 |
|---|---|---|
| committer | Jeff Law <law@gcc.gnu.org> | 2015-09-21 11:09:53 -0600 |
| commit | d7b00a16de70d84dce94a1f760265497f3408a7b (patch) | |
| tree | c5918fcbec8344440b4eb7beeb5d489477c19b60 | |
| parent | bdaaa8b70f8e76b2743ee7bafc438e499411753f (diff) | |
| download | gcc-d7b00a16de70d84dce94a1f760265497f3408a7b.zip gcc-d7b00a16de70d84dce94a1f760265497f3408a7b.tar.gz gcc-d7b00a16de70d84dce94a1f760265497f3408a7b.tar.bz2 | |
[PATCH] Fix undefined behavior in h8300 backend
* config/h8300/h8300.md (andsi3_ashift_n_lower): Avoid undefined
behavior.
* gcc.target/h8300/andsi3_ashift_n_lower.c: New test.
From-SVN: r227978
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/config/h8300/h8300.md | 3 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/h8300/andsi3_ashift_n_lower.c | 7 |
4 files changed, 18 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c25888a..b6527de 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2015-09-21 Jeff Law <law@redhat.com> + + * config/h8300/h8300.md (andsi3_ashift_n_lower): Avoid undefined + behavior. + 2015-09-21 Ulrich Weigand <Ulrich.Weigand@de.ibm.com> * config/spu/spu.c (spu_expand_insv): Avoid undefined behavior. diff --git a/gcc/config/h8300/h8300.md b/gcc/config/h8300/h8300.md index 4079b30..52213ac 100644 --- a/gcc/config/h8300/h8300.md +++ b/gcc/config/h8300/h8300.md @@ -3914,7 +3914,8 @@ (clobber (match_scratch:QI 4 "=X,&r"))] "(TARGET_H8300H || TARGET_H8300S) && INTVAL (operands[2]) <= 15 - && INTVAL (operands[3]) == ((-1 << INTVAL (operands[2])) & 0xffff)" + && UINTVAL (operands[3]) == ((HOST_WIDE_INT_M1U << INTVAL (operands[2])) + & 0xffff)" "#" "&& reload_completed" [(parallel [(set (match_dup 5) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c65469f..7afd523 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2015-09-21 Jeff Law <law@redhat.com> + + * gcc.target/h8300/andsi3_ashift_n_lower.c: New test. + 2015-09-21 Ville Voutilainen <ville.voutilainen@gmail.com> Complete the implementation of N4230, Nested namespace definition. diff --git a/gcc/testsuite/gcc.target/h8300/andsi3_ashift_n_lower.c b/gcc/testsuite/gcc.target/h8300/andsi3_ashift_n_lower.c new file mode 100644 index 0000000..8cacc52 --- /dev/null +++ b/gcc/testsuite/gcc.target/h8300/andsi3_ashift_n_lower.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* { dg-options "-mh -O2 -fomit-frame-pointer" } */ +/* { dg-final { scan-assembler-times "extu" 1 } } */ + +unsigned long foo(unsigned long a) + { return (a << 4) & 0xffff; } + |