diff options
| author | Harald Anlauf <anlauf@gmx.de> | 2023-11-23 22:48:38 +0100 |
|---|---|---|
| committer | Harald Anlauf <anlauf@gmx.de> | 2023-11-26 20:10:20 +0100 |
| commit | c9d029ba2ceb435e31492c1f3f0fd3edf0e386be (patch) | |
| tree | ad58c9235693685fca039d938a84549ef40dc772 | |
| parent | 22f42cdcb091b7046f4d687342ac0913efb95838 (diff) | |
| download | gcc-c9d029ba2ceb435e31492c1f3f0fd3edf0e386be.zip gcc-c9d029ba2ceb435e31492c1f3f0fd3edf0e386be.tar.gz gcc-c9d029ba2ceb435e31492c1f3f0fd3edf0e386be.tar.bz2 | |
Fortran: avoid obsolescence warning for COMMON with submodule [PR111880]
gcc/fortran/ChangeLog:
PR fortran/111880
* resolve.cc (resolve_common_vars): Do not call gfc_add_in_common
for symbols that are USE associated or used in a submodule.
gcc/testsuite/ChangeLog:
PR fortran/111880
* gfortran.dg/pr111880.f90: New test.
| -rw-r--r-- | gcc/fortran/resolve.cc | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gfortran.dg/pr111880.f90 | 22 |
2 files changed, 24 insertions, 2 deletions
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 81a1465..166b702 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -986,8 +986,8 @@ resolve_common_vars (gfc_common_head *common_block, bool named_common) /* gfc_add_in_common may have been called before, but the reported errors have been ignored to continue parsing. - We do the checks again here. */ - if (!csym->attr.use_assoc) + We do the checks again here, unless the symbol is USE associated. */ + if (!csym->attr.use_assoc && !csym->attr.used_in_submodule) { gfc_add_in_common (&csym->attr, csym->name, &common_block->where); gfc_notify_std (GFC_STD_F2018_OBS, "COMMON block at %L", diff --git a/gcc/testsuite/gfortran.dg/pr111880.f90 b/gcc/testsuite/gfortran.dg/pr111880.f90 new file mode 100644 index 0000000..c0cd98a --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr111880.f90 @@ -0,0 +1,22 @@ +! { dg-do compile } +! { dg-options "-std=f2018" } +! PR fortran/111880 - redundant warning of obsolescent COMMON with submodule + +module third_party_module + integer :: some_param + common /not_my_code/ some_param ! { dg-warning "COMMON block" } +end module third_party_module + +module foo + use third_party_module + interface + module subroutine bar() + end subroutine bar + end interface +end module foo + +submodule (foo) foo_submod ! We do not need a warning here! +contains + module procedure bar + end procedure bar +end submodule foo_submod |