diff options
| author | Richard Biener <rguenther@suse.de> | 2022-07-13 08:27:57 +0200 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2022-07-13 08:30:44 +0200 |
| commit | c479c40f8c8fee0fb70e8a365b61c55739f448e1 (patch) | |
| tree | 5c5073165e5e46b4a702fefaf92bc72394d19223 | |
| parent | 43997608a0887341160d50f83ad2d0159b387aae (diff) | |
| download | gcc-c479c40f8c8fee0fb70e8a365b61c55739f448e1.zip gcc-c479c40f8c8fee0fb70e8a365b61c55739f448e1.tar.gz gcc-c479c40f8c8fee0fb70e8a365b61c55739f448e1.tar.bz2 | |
tree-optimization/106249 - unroll-and-jam and LC SSA upate
When I delayed the LC SSA update in unroll-and-jam this exposed
an issue that tree_transform_and_unroll_loop does a full function
LC SSA verification when new_loop is NULL (when it doesn't need to
do versioning). That wasn't intended. I also took the chance
to make the versioning in tree_transform_and_unroll_loop use
TODO_update_ssa_nophi for the loop versioning SSA update which
I somehow missed earlier.
PR tree-optimization/106249
* tree-ssa-loop-manip.cc (tree_transform_and_unroll_loop):
Only verify LC SSA of the new_loop if we created it.
Use TODO_update_ssa_nophi for the SSA update after versioning
the loop.
* gcc.dg/pr106249.c: New testcase.
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr106249.c | 16 | ||||
| -rw-r--r-- | gcc/tree-ssa-loop-manip.cc | 5 |
2 files changed, 19 insertions, 2 deletions
diff --git a/gcc/testsuite/gcc.dg/pr106249.c b/gcc/testsuite/gcc.dg/pr106249.c new file mode 100644 index 0000000..f97b07f --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr106249.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-options "-O -floop-unroll-and-jam --param unroll-jam-min-percent=0" } */ + +void +foo (double *arr) +{ + int i, j; + + for (i = 0; i < 4; ++i) + for (j = 0; j < 4; ++j) + arr[j] = 0; + + for (i = 1; i < 4; ++i) + for (j = 0; j < 4; ++j) + arr[j] = 1.0 / (i + 1); +} diff --git a/gcc/tree-ssa-loop-manip.cc b/gcc/tree-ssa-loop-manip.cc index c531f1f..410a851 100644 --- a/gcc/tree-ssa-loop-manip.cc +++ b/gcc/tree-ssa-loop-manip.cc @@ -1208,7 +1208,7 @@ tree_transform_and_unroll_loop (class loop *loop, unsigned factor, profile_probability::guessed_always (), true); gcc_assert (new_loop != NULL); - update_ssa (TODO_update_ssa); + update_ssa (TODO_update_ssa_no_phi); /* Prepare the cfg and update the phi nodes. Move the loop exit to the loop latch (and make its condition dummy, for the moment). */ @@ -1428,7 +1428,8 @@ tree_transform_and_unroll_loop (class loop *loop, unsigned factor, checking_verify_flow_info (); checking_verify_loop_structure (); checking_verify_loop_closed_ssa (true, loop); - checking_verify_loop_closed_ssa (true, new_loop); + if (new_loop) + checking_verify_loop_closed_ssa (true, new_loop); } /* Wrapper over tree_transform_and_unroll_loop for case we do not |