aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Mitchell <mark@codesourcery.com>2005-10-02 21:28:50 +0000
committerMark Mitchell <mmitchel@gcc.gnu.org>2005-10-02 21:28:50 +0000
commitc0ad5a317379afbc3dfb0fb1fd4e6fdb98aab8e2 (patch)
tree10dca596efc248e2d42da67bbf26853432593ca3
parentb19bb8b0445fca3bef3d30d244395c2319c1bf9c (diff)
downloadgcc-c0ad5a317379afbc3dfb0fb1fd4e6fdb98aab8e2.zip
gcc-c0ad5a317379afbc3dfb0fb1fd4e6fdb98aab8e2.tar.gz
gcc-c0ad5a317379afbc3dfb0fb1fd4e6fdb98aab8e2.tar.bz2
re PR c++/23840 (Bogus "invalid lvalue in unary '&'" diagnostic and ICE with va_arg)
PR c++/23840 * tree.c (lvalue_p1): A VA_ARG_EXPR with class type is an lvalue, when class rvalues are lvalues. PR c++/23840 * g++.dg/expr/stdarg1.C: New test. From-SVN: r104877
-rw-r--r--gcc/cp/ChangeLog6
-rw-r--r--gcc/cp/tree.c6
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/expr/stdarg1.C13
4 files changed, 29 insertions, 1 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index f4255d6..14fc98f 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2005-10-02 Mark Mitchell <mark@codesourcery.com>
+
+ PR c++/23840
+ * tree.c (lvalue_p1): A VA_ARG_EXPR with class type is an lvalue,
+ when class rvalues are lvalues.
+
2005-09-28 Mark Mitchell <mark@codesourcery.com>
PR c++/16782
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index 9c28f13..954a809 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -158,8 +158,12 @@ lvalue_p_1 (tree ref,
case TARGET_EXPR:
return treat_class_rvalues_as_lvalues ? clk_class : clk_none;
- case CALL_EXPR:
case VA_ARG_EXPR:
+ return (treat_class_rvalues_as_lvalues
+ && CLASS_TYPE_P (TREE_TYPE (ref))
+ ? clk_class : clk_none);
+
+ case CALL_EXPR:
/* Any class-valued call would be wrapped in a TARGET_EXPR. */
return clk_none;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 98bfad4..67105b0 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2005-10-02 Mark Mitchell <mark@codesourcery.com>
+
+ PR c++/23840
+ * g++.dg/expr/stdarg1.C: New test.
+
2005-10-02 Diego Novillo <dnovillo@redhat.com>
PR 24142
diff --git a/gcc/testsuite/g++.dg/expr/stdarg1.C b/gcc/testsuite/g++.dg/expr/stdarg1.C
new file mode 100644
index 0000000..85b6f74
--- /dev/null
+++ b/gcc/testsuite/g++.dg/expr/stdarg1.C
@@ -0,0 +1,13 @@
+// PR c++/23840
+
+#include <stdarg.h>
+struct S
+{
+ int f(int);
+};
+void f(int i, ...)
+{
+ va_list ap;
+ va_start (ap, i);
+ va_arg (ap, S).f(0);
+}