diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2017-03-31 08:32:46 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2017-03-31 08:32:46 +0200 |
| commit | a7d551541989a53c964d5cc54359069bf4cf919a (patch) | |
| tree | fea535e8d66f9e488a837e68fe8734100a548f95 | |
| parent | 005f12bf67e60ada0757470be80fe69799a83ebc (diff) | |
| download | gcc-a7d551541989a53c964d5cc54359069bf4cf919a.zip gcc-a7d551541989a53c964d5cc54359069bf4cf919a.tar.gz gcc-a7d551541989a53c964d5cc54359069bf4cf919a.tar.bz2 | |
re PR middle-end/80163 (ICE on hopefully valid code)
PR middle-end/80163
* varasm.c (initializer_constant_valid_p_1): Disallow sign-extending
conversions to integer types wider than word and pointer.
* gcc.dg/pr80163.c: New test.
From-SVN: r246607
| -rw-r--r-- | gcc/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 3 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr80163.c | 22 | ||||
| -rw-r--r-- | gcc/varasm.c | 11 |
4 files changed, 38 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 1dca2cf..65aaca7 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2017-03-31 Jakub Jelinek <jakub@redhat.com> + PR middle-end/80163 + * varasm.c (initializer_constant_valid_p_1): Disallow sign-extending + conversions to integer types wider than word and pointer. + PR debug/80025 * cselib.h (rtx_equal_for_cselib_1): Add depth argument. (rtx_equal_for_cselib_p): Pass 0 to it. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 1b30193..af79d42 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2017-03-31 Jakub Jelinek <jakub@redhat.com> + PR middle-end/80163 + * gcc.dg/pr80163.c: New test. + PR debug/80025 * gcc.dg/torture/pr80025.c: New test. diff --git a/gcc/testsuite/gcc.dg/pr80163.c b/gcc/testsuite/gcc.dg/pr80163.c new file mode 100644 index 0000000..37a7abd --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr80163.c @@ -0,0 +1,22 @@ +/* PR middle-end/80163 */ +/* { dg-do compile { target int128 } } */ +/* { dg-options "-O0" } */ + +void bar (void); + +__int128_t * +foo (void) +{ +a: + bar (); +b:; + static __int128_t d = (long) &&a - (long) &&b; /* { dg-error "initializer element is not computable at load time" } */ + return &d; +} + +__int128_t * +baz (void) +{ + static __int128_t d = (long) (3 * 4); + return &d; +} diff --git a/gcc/varasm.c b/gcc/varasm.c index 11a8ac4..05e48a5 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -4472,8 +4472,15 @@ initializer_constant_valid_p_1 (tree value, tree endtype, tree *cache) return initializer_constant_valid_p_1 (src, endtype, cache); /* Allow conversions between other integer types only if - explicit value. */ - if (INTEGRAL_TYPE_P (dest_type) && INTEGRAL_TYPE_P (src_type)) + explicit value. Don't allow sign-extension to a type larger + than word and pointer, there aren't relocations that would + allow to sign extend it to a wider type. */ + if (INTEGRAL_TYPE_P (dest_type) + && INTEGRAL_TYPE_P (src_type) + && (TYPE_UNSIGNED (src_type) + || TYPE_PRECISION (dest_type) <= TYPE_PRECISION (src_type) + || TYPE_PRECISION (dest_type) <= BITS_PER_WORD + || TYPE_PRECISION (dest_type) <= POINTER_SIZE)) { tree inner = initializer_constant_valid_p_1 (src, endtype, cache); if (inner == null_pointer_node) |