diff options
author | Jason Merrill <jason@redhat.com> | 2021-04-07 14:55:48 -0400 |
---|---|---|
committer | Jason Merrill <jason@redhat.com> | 2021-04-07 15:27:47 -0400 |
commit | a528594cf9a74e5a0fbac13ef673064ed73e1b89 (patch) | |
tree | 5dbb8daeeb056ef015ea9d873737e5cd13014950 | |
parent | 12029c04d01c7ba0f775cdc208edf29490ee5db6 (diff) | |
download | gcc-a528594cf9a74e5a0fbac13ef673064ed73e1b89.zip gcc-a528594cf9a74e5a0fbac13ef673064ed73e1b89.tar.gz gcc-a528594cf9a74e5a0fbac13ef673064ed73e1b89.tar.bz2 |
c++: using overloaded with local decl [PR92918]
The problem here was that the lookup for 'impl' when parsing the template
only found the using-declaration, not the member function declaration.
This happened because when trying to add the member function declaration,
push_class_level_binding_1 saw that the current binding was a USING_DECL and
the new value is an overload, and decided to just return success.
That 'return true' dates back to r69921. In
https://gcc.gnu.org/pipermail/gcc-patches/2003-July/110632.html Nathan
mentions that we only push dependent USING_DECLs, which is no longer the
case; now that we retain more USING_DECLs, handling this case like the other
overloaded function cases seems like the obvious solution.
gcc/cp/ChangeLog:
PR c++/92918
* name-lookup.c (push_class_level_binding_1): Do overload a new
function with a previous using-declaration.
gcc/testsuite/ChangeLog:
PR c++/92918
* g++.dg/lookup/using66.C: New test.
-rw-r--r-- | gcc/cp/name-lookup.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/lookup/using66.C | 23 |
2 files changed, 24 insertions, 1 deletions
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name-lookup.c index 3bce3d5..4e84e2f 100644 --- a/gcc/cp/name-lookup.c +++ b/gcc/cp/name-lookup.c @@ -5520,7 +5520,7 @@ push_class_level_binding_1 (tree name, tree x) old_decl = bval; else if (TREE_CODE (bval) == USING_DECL && OVL_P (target_decl)) - return true; + old_decl = bval; else if (OVL_P (target_decl) && OVL_P (target_bval)) old_decl = bval; diff --git a/gcc/testsuite/g++.dg/lookup/using66.C b/gcc/testsuite/g++.dg/lookup/using66.C new file mode 100644 index 0000000..02383bb --- /dev/null +++ b/gcc/testsuite/g++.dg/lookup/using66.C @@ -0,0 +1,23 @@ +// PR c++/92918 +// { dg-do compile { target c++11 } } + +struct Base03 +{ + static void impl(); +}; + +struct Problem : Base03 +{ + using Base03::impl; + static int impl(char const *); + + template <typename T> + auto f(const T &t) const + -> decltype(impl(t)) + { + return impl(t); + } +}; + +Problem t; +int i = t.f("42"); |