aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Merrill <jason@redhat.com>2006-09-06 01:25:29 -0400
committerJason Merrill <jason@gcc.gnu.org>2006-09-06 01:25:29 -0400
commita1a9524971df4d4991760ccb1189049f067c7e80 (patch)
treefb1503c26b7e4fe433739ebe1815160abee96c53
parent2635450a7f327411ac8293eb35cf5cf4083f9cfb (diff)
downloadgcc-a1a9524971df4d4991760ccb1189049f067c7e80.zip
gcc-a1a9524971df4d4991760ccb1189049f067c7e80.tar.gz
gcc-a1a9524971df4d4991760ccb1189049f067c7e80.tar.bz2
re PR c++/26671 (Missing "warning: reference to local variable returned")
PR c++/26671 * typeck.c (maybe_warn_about_returning_address_of_local): Look through COMPONENT_REF and ARRAY_REF. From-SVN: r116714
-rw-r--r--gcc/cp/ChangeLog4
-rw-r--r--gcc/cp/typeck.c4
-rw-r--r--gcc/testsuite/g++.dg/warn/return-reference2.C21
3 files changed, 29 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 3b53412..014c76b 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,9 @@
2006-09-05 Jason Merrill <jason@redhat.com>
+ PR c++/26671
+ * typeck.c (maybe_warn_about_returning_address_of_local): Look
+ through COMPONENT_REF and ARRAY_REF.
+
PR c++/26102
* name-lookup.c (do_class_using_decl): Try to find the base even
if bases_dependent_p.
diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index c07a78d..220be7e 100644
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -6365,6 +6365,10 @@ maybe_warn_about_returning_address_of_local (tree retval)
}
}
+ while (TREE_CODE (whats_returned) == COMPONENT_REF
+ || TREE_CODE (whats_returned) == ARRAY_REF)
+ whats_returned = TREE_OPERAND (whats_returned, 0);
+
if (DECL_P (whats_returned)
&& DECL_NAME (whats_returned)
&& DECL_FUNCTION_SCOPE_P (whats_returned)
diff --git a/gcc/testsuite/g++.dg/warn/return-reference2.C b/gcc/testsuite/g++.dg/warn/return-reference2.C
new file mode 100644
index 0000000..96e44a1
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/return-reference2.C
@@ -0,0 +1,21 @@
+// PR c++/26671
+
+class A
+{
+public:
+ int first;
+ int second;
+
+};
+
+int &f()
+{
+ A a; // { dg-error "local" }
+ return a.second;
+}
+
+int &g()
+{
+ int ar[42]; // { dg-error "local" }
+ return ar[20];
+}