diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2020-12-19 12:46:40 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2020-12-19 12:46:40 +0100 |
| commit | 9032d2b2414ed22e53a9980a51b835d3caf83c48 (patch) | |
| tree | dd0f75fc0f4732b67a58b2027458661015e5c5d7 | |
| parent | b1a2242e24fe984711214b7546cb993cfe45ace8 (diff) | |
| download | gcc-9032d2b2414ed22e53a9980a51b835d3caf83c48.zip gcc-9032d2b2414ed22e53a9980a51b835d3caf83c48.tar.gz gcc-9032d2b2414ed22e53a9980a51b835d3caf83c48.tar.bz2 | |
bswap: Fix up a thinko with empty CONSTRUCTORs [PR98378]
The code I've added recently in find_bswap_or_nop for VECTOR CONSTRUCTORs
is missing punt on an important case - namely empty CONSTRUCTORs, because in that
case the loop will not initialize *n and the code after the loop will then
use the uninitialized structure.
2020-12-19 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/98378
* gimple-ssa-store-merging.c (find_bswap_or_nop): Punt if CONSTRUCTOR
has no elements.
| -rw-r--r-- | gcc/gimple-ssa-store-merging.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/gcc/gimple-ssa-store-merging.c b/gcc/gimple-ssa-store-merging.c index 2894205f..2ab51e2 100644 --- a/gcc/gimple-ssa-store-merging.c +++ b/gcc/gimple-ssa-store-merging.c @@ -873,6 +873,8 @@ find_bswap_or_nop (gimple *stmt, struct symbolic_number *n, bool *bswap) if (sz != 16 && sz != 32 && sz != 64) return NULL; tree rhs = gimple_assign_rhs1 (stmt); + if (CONSTRUCTOR_NELTS (rhs) == 0) + return NULL; tree eltype = TREE_TYPE (TREE_TYPE (rhs)); unsigned HOST_WIDE_INT eltsz = int_size_in_bytes (eltype) * BITS_PER_UNIT; |