aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Merrill <jason@redhat.com>2011-10-19 18:29:15 -0400
committerJason Merrill <jason@gcc.gnu.org>2011-10-19 18:29:15 -0400
commit875bcfdbf412ba625cf9ee9e1bd6610c0ad5b5f8 (patch)
tree4c9775c1197e68fdedd21754444fa1abc3c19c9a
parentf33fa066984c6f29eee20db130133354a5ec995c (diff)
downloadgcc-875bcfdbf412ba625cf9ee9e1bd6610c0ad5b5f8.zip
gcc-875bcfdbf412ba625cf9ee9e1bd6610c0ad5b5f8.tar.gz
gcc-875bcfdbf412ba625cf9ee9e1bd6610c0ad5b5f8.tar.bz2
re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in default argument)
PR c++/50793 * tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST. From-SVN: r180227
-rw-r--r--gcc/cp/ChangeLog5
-rw-r--r--gcc/cp/tree.c8
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/init/value9.C32
4 files changed, 48 insertions, 2 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 3b5c14c..8e9bb4a 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-19 Jason Merrill <jason@redhat.com>
+
+ PR c++/50793
+ * tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST.
+
2011-10-19 Roland Stigge <stigge@antcom.de>
PR translation/49704
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index 75aa265..d023eb8 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -1879,8 +1879,12 @@ bot_manip (tree* tp, int* walk_subtrees, void* data)
tree u;
if (TREE_CODE (TREE_OPERAND (t, 1)) == AGGR_INIT_EXPR)
- u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1),
- tf_warning_or_error);
+ {
+ u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1),
+ tf_warning_or_error);
+ if (AGGR_INIT_ZERO_FIRST (TREE_OPERAND (t, 1)))
+ AGGR_INIT_ZERO_FIRST (TREE_OPERAND (u, 1)) = true;
+ }
else
u = build_target_expr_with_type (TREE_OPERAND (t, 1), TREE_TYPE (t),
tf_warning_or_error);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 1239207..173f195 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-19 Jason Merrill <jason@redhat.com>
+
+ PR c++/50793
+ * g++.dg/init/value9.C: New.
+
2011-10-19 Jakub Jelinek <jakub@redhat.com>
* gcc.dg/torture/vshuf-32.inc: Add interleave permutations.
diff --git a/gcc/testsuite/g++.dg/init/value9.C b/gcc/testsuite/g++.dg/init/value9.C
new file mode 100644
index 0000000..4899bd8
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/value9.C
@@ -0,0 +1,32 @@
+// PR c++/50793
+// { dg-do run }
+
+struct NonTrivial
+{
+ NonTrivial() { }
+};
+
+struct S
+{
+ NonTrivial nt;
+ int i;
+};
+
+int f(S s)
+{
+ s.i = 0xdeadbeef;
+ return s.i;
+}
+
+int g(S s = S())
+{
+ return s.i;
+}
+
+int main()
+{
+ f(S()); // make stack dirty
+
+ if ( g() )
+ __builtin_abort();
+}