aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlya Leoshkevich <iii@linux.ibm.com>2022-01-28 13:34:24 +0100
committerIlya Leoshkevich <iii@linux.ibm.com>2022-02-01 22:13:38 +0100
commit8753b13a31c777cdab0265dae0b68534247908f7 (patch)
treeaa9adbe1c533fd1890d66732fae83f0db9b726ff
parent447047a8f95c6bf4b1873f390c833e91aa8af18c (diff)
downloadgcc-8753b13a31c777cdab0265dae0b68534247908f7.zip
gcc-8753b13a31c777cdab0265dae0b68534247908f7.tar.gz
gcc-8753b13a31c777cdab0265dae0b68534247908f7.tar.bz2
IBM Z: fix `section type conflict` with -mindirect-branch-table
s390_code_end () puts indirect branch tables into separate sections and tries to switch back to wherever it was in the beginning by calling switch_to_section (current_function_section ()). First of all, this is unnecessary - the other backends don't do it. Furthermore, at this time there is no current function, but if the last processed function was cold, in_cold_section_p remains set. This causes targetm.asm_out.function_section () to call targetm.section_type_flags (), which in absence of current function decl classifies the section as SECTION_WRITE. This causes a section type conflict with the existing SECTION_CODE. gcc/ChangeLog: * config/s390/s390.cc (s390_code_end): Do not switch back to code section. gcc/testsuite/ChangeLog: * gcc.target/s390/nobp-section-type-conflict.c: New test.
-rw-r--r--gcc/config/s390/s390.cc1
-rw-r--r--gcc/testsuite/gcc.target/s390/nobp-section-type-conflict.c22
2 files changed, 22 insertions, 1 deletions
diff --git a/gcc/config/s390/s390.cc b/gcc/config/s390/s390.cc
index 43c5c72..2db12d4 100644
--- a/gcc/config/s390/s390.cc
+++ b/gcc/config/s390/s390.cc
@@ -16809,7 +16809,6 @@ s390_code_end (void)
assemble_name_raw (asm_out_file, label_start);
fputs ("-.\n", asm_out_file);
}
- switch_to_section (current_function_section ());
}
}
}
diff --git a/gcc/testsuite/gcc.target/s390/nobp-section-type-conflict.c b/gcc/testsuite/gcc.target/s390/nobp-section-type-conflict.c
new file mode 100644
index 0000000..5d78bc9
--- /dev/null
+++ b/gcc/testsuite/gcc.target/s390/nobp-section-type-conflict.c
@@ -0,0 +1,22 @@
+/* Checks that we don't get error: section type conflict with ‘put_page’. */
+
+/* { dg-do compile } */
+/* { dg-options "-mindirect-branch=thunk-extern -mfunction-return=thunk-extern -mindirect-branch-table -O2" } */
+
+int a;
+int b (void);
+void c (int);
+
+static void
+put_page (void)
+{
+ if (b ())
+ c (a);
+}
+
+__attribute__ ((__section__ (".init.text"), __cold__)) void
+d (void)
+{
+ put_page ();
+ put_page ();
+}