diff options
| author | Tamar Christina <tamar.christina@arm.com> | 2023-11-16 12:11:22 +0000 |
|---|---|---|
| committer | Tamar Christina <tamar.christina@arm.com> | 2023-11-16 12:11:55 +0000 |
| commit | 7a496b7ce105185be12e023e749c90d5f7561879 (patch) | |
| tree | 60b939cf7ed85a59cd0c8d49fd2375f4fa61c137 | |
| parent | ec35fdc9576d3907973667b57932b21514ee5062 (diff) | |
| download | gcc-7a496b7ce105185be12e023e749c90d5f7561879.zip gcc-7a496b7ce105185be12e023e749c90d5f7561879.tar.gz gcc-7a496b7ce105185be12e023e749c90d5f7561879.tar.bz2 | |
middle-end: skip checking loop exits if loop malformed [PR111878]
Before my refactoring if the loop->latch was incorrect then find_loop_location
skipped checking the edges and would eventually return a dummy location.
It turns out that a loop can have
loops_state_satisfies_p (LOOPS_HAVE_RECORDED_EXITS) but also not have a latch
in which case get_loop_exit_edges traps.
This restores the old behavior.
gcc/ChangeLog:
PR tree-optimization/111878
* tree-vect-loop-manip.cc (find_loop_location): Skip edges check if
latch incorrect.
gcc/testsuite/ChangeLog:
PR tree-optimization/111878
* gcc.dg/graphite/pr111878.c: New test.
| -rw-r--r-- | gcc/testsuite/gcc.dg/graphite/pr111878.c | 19 | ||||
| -rw-r--r-- | gcc/tree-vect-loop-manip.cc | 4 |
2 files changed, 23 insertions, 0 deletions
diff --git a/gcc/testsuite/gcc.dg/graphite/pr111878.c b/gcc/testsuite/gcc.dg/graphite/pr111878.c new file mode 100644 index 0000000..6722910 --- /dev/null +++ b/gcc/testsuite/gcc.dg/graphite/pr111878.c @@ -0,0 +1,19 @@ +/* { dg-options "-O3 -fgraphite-identity -fsave-optimization-record" } */ + +int long_c2i_ltmp; +int *long_c2i_cont; + +void +long_c2i (long utmp, int i) +{ + int neg = 1; + switch (long_c2i_cont[0]) + case 0: + neg = 0; + for (; i; i++) + if (neg) + utmp |= long_c2i_cont[i] ^ 5; + else + utmp |= long_c2i_cont[i]; + long_c2i_ltmp = utmp; +} diff --git a/gcc/tree-vect-loop-manip.cc b/gcc/tree-vect-loop-manip.cc index b916127..bcd90a3 100644 --- a/gcc/tree-vect-loop-manip.cc +++ b/gcc/tree-vect-loop-manip.cc @@ -1792,6 +1792,10 @@ find_loop_location (class loop *loop) if (!loop) return dump_user_location_t (); + /* For the root of the loop tree return the function location. */ + if (!loop_outer (loop)) + return dump_user_location_t::from_function_decl (cfun->decl); + if (loops_state_satisfies_p (LOOPS_HAVE_RECORDED_EXITS)) { /* We only care about the loop location, so use any exit with location |