diff options
| author | Martin Jambor <mjambor@suse.cz> | 2023-10-03 19:09:33 +0200 |
|---|---|---|
| committer | Martin Jambor <mjambor@suse.cz> | 2023-10-03 19:10:01 +0200 |
| commit | 5f18797450549e4f67a75ee2b08cd639ae1fa54d (patch) | |
| tree | c4bfe5458aed8f8ed2416a663bb187911adeab73 | |
| parent | ed8fe3b1203b936d870d1ab79e66d34f9c955738 (diff) | |
| download | gcc-5f18797450549e4f67a75ee2b08cd639ae1fa54d.zip gcc-5f18797450549e4f67a75ee2b08cd639ae1fa54d.tar.gz gcc-5f18797450549e4f67a75ee2b08cd639ae1fa54d.tar.bz2 | |
contrib/mklog.py: Fix issues reported by flake8
The testing infrastructure built by Martin Liška contains checking a
few python scripts in contrib witha tool flake8. That tool recently
complains that:
contrib/mklog.py:360:45: E711 comparison to None should be 'if cond is None:'
contrib/mklog.py:362:1: E305 expected 2 blank lines after class or function definition, found 1
I'd like to silence these with the following, hopefully trivial,
changes. However, I have only tested the changes by running flake8
again and running ./contrib/mklog.py --help.
Is this good for trunk? (Or should I stop using flake8 instead?)
Thanks,
Martin
contrib/ChangeLog:
2023-10-03 Martin Jambor <mjambor@suse.cz>
* mklog.py (skip_line_in_changelog): Compare to None using is instead
of ==, add an extra newline after the function.
| -rwxr-xr-x | contrib/mklog.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/contrib/mklog.py b/contrib/mklog.py index effe5aa1..1c2c321 100755 --- a/contrib/mklog.py +++ b/contrib/mklog.py @@ -357,7 +357,8 @@ def update_copyright(data): def skip_line_in_changelog(line): - return FIRST_LINE_OF_END_RE.match(line) == None + return FIRST_LINE_OF_END_RE.match(line) is None + if __name__ == '__main__': extra_args = os.getenv('GCC_MKLOG_ARGS') |