aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Malcolm <dmalcolm@redhat.com>2018-08-06 16:25:27 +0000
committerDavid Malcolm <dmalcolm@gcc.gnu.org>2018-08-06 16:25:27 +0000
commit5242b3cb24325fb1ff32a71383ae2e7f855b2c06 (patch)
tree548098ef931ec0b1f57de717cfcadca4cf2f10e4
parent27ee6398a63f587d23c6da8a12ce8adb0cd31cfb (diff)
downloadgcc-5242b3cb24325fb1ff32a71383ae2e7f855b2c06.zip
gcc-5242b3cb24325fb1ff32a71383ae2e7f855b2c06.tar.gz
gcc-5242b3cb24325fb1ff32a71383ae2e7f855b2c06.tar.bz2
Fix memory leak in selftest::test_expansion_to_rtl
"make selftest-valgrind" shows: 187 bytes in 1 blocks are definitely lost in loss record 567 of 669 at 0x4A081D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x1F08260: xcalloc (xmalloc.c:162) by 0xB24F32: init_emit() (emit-rtl.c:5843) by 0xC10080: prepare_function_start() (function.c:4803) by 0xC10254: init_function_start(tree_node*) (function.c:4877) by 0x1CDF92A: selftest::test_expansion_to_rtl() (function-tests.c:595) by 0x1CE007C: selftest::function_tests_c_tests() (function-tests.c:676) by 0x1E010E7: selftest::run_tests() (selftest-run-tests.c:98) by 0x1062D1E: toplev::run_self_tests() (toplev.c:2225) by 0x1062F40: toplev::main(int, char**) (toplev.c:2303) by 0x1E5B90A: main (main.c:39) The allocation in question is: crtl->emit.regno_pointer_align = XCNEWVEC (unsigned char, crtl->emit.regno_pointer_align_length); This patch fixes this leak (and makes the output of "make selftest-valgrind" clean) by calling free_after_compilation at the end of the selftest in question. gcc/ChangeLog: * function-tests.c (selftest::test_expansion_to_rtl): Call free_after_compilation. From-SVN: r263339
-rw-r--r--gcc/ChangeLog5
-rw-r--r--gcc/function-tests.c1
2 files changed, 6 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 05bd803..b9a59d9 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-06 David Malcolm <dmalcolm@redhat.com>
+
+ * function-tests.c (selftest::test_expansion_to_rtl): Call
+ free_after_compilation.
+
2018-08-06 Alan Hayward <alan.hayward@arm.com>
* config/aarch64/aarch64.md: Add clobber highs to tls_desc.
diff --git a/gcc/function-tests.c b/gcc/function-tests.c
index 1b5ebf3..196b3a3 100644
--- a/gcc/function-tests.c
+++ b/gcc/function-tests.c
@@ -661,6 +661,7 @@ test_expansion_to_rtl ()
ASSERT_STR_CONTAINS (dump, ") ;; function \"test_fn\"\n");
free (dump);
+ free_after_compilation (fun);
}
/* Run all of the selftests within this file. */