aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHarald Anlauf <anlauf@gmx.de>2023-01-23 22:13:44 +0100
committerHarald Anlauf <anlauf@gmx.de>2023-01-23 22:46:30 +0100
commit51767f31878a95161142254dca7119b409699670 (patch)
tree170477ca595eb73fdbd64c33424fd8544b1ab7b7
parente3585e6acdfd5c1793f877476647d2521620c95c (diff)
downloadgcc-51767f31878a95161142254dca7119b409699670.zip
gcc-51767f31878a95161142254dca7119b409699670.tar.gz
gcc-51767f31878a95161142254dca7119b409699670.tar.bz2
Fortran: fix NULL pointer dereference in gfc_check_dependency [PR108502]
gcc/fortran/ChangeLog: PR fortran/108502 * dependency.cc (gfc_check_dependency): Prevent NULL pointer dereference while recursively checking expressions. gcc/testsuite/ChangeLog: PR fortran/108502 * gfortran.dg/pr108502.f90: New test.
-rw-r--r--gcc/fortran/dependency.cc5
-rw-r--r--gcc/testsuite/gfortran.dg/pr108502.f9012
2 files changed, 17 insertions, 0 deletions
diff --git a/gcc/fortran/dependency.cc b/gcc/fortran/dependency.cc
index 43417a6..9117825 100644
--- a/gcc/fortran/dependency.cc
+++ b/gcc/fortran/dependency.cc
@@ -1292,6 +1292,11 @@ gfc_check_dependency (gfc_expr *expr1, gfc_expr *expr2, bool identical)
if (expr1->expr_type != EXPR_VARIABLE)
gfc_internal_error ("gfc_check_dependency: expecting an EXPR_VARIABLE");
+ /* Prevent NULL pointer dereference while recursively analyzing invalid
+ expressions. */
+ if (expr2 == NULL)
+ return 0;
+
switch (expr2->expr_type)
{
case EXPR_OP:
diff --git a/gcc/testsuite/gfortran.dg/pr108502.f90 b/gcc/testsuite/gfortran.dg/pr108502.f90
new file mode 100644
index 0000000..45f7384
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr108502.f90
@@ -0,0 +1,12 @@
+! { dg-do compile }
+! { dg-options "-O2 -ffrontend-optimize" }
+! PR fortran/108502 - ICE in gfc_check_dependency
+! Contributed by G.Steinmetz
+
+integer function n()
+ integer :: a(1)
+ a = [1] / 0
+end
+program p
+ integer :: b = n() ! { dg-error "must be an intrinsic function" }
+end