aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Herron <herron.philip@googlemail.com>2025-04-16 17:13:04 +0100
committerPhilip Herron <philip.herron@embecosm.com>2025-04-16 22:19:17 +0000
commit50a90f12af84ba2d203a0510bbeb41a383981303 (patch)
treea4c06682ba956ea97f742ab1fd4dd3379d686a7e
parent95615a1ab48f1493fef21bb9f5f465f02ff527e4 (diff)
downloadgcc-50a90f12af84ba2d203a0510bbeb41a383981303.zip
gcc-50a90f12af84ba2d203a0510bbeb41a383981303.tar.gz
gcc-50a90f12af84ba2d203a0510bbeb41a383981303.tar.bz2
gccrs: Fix ICE when checking shift's which are behind array refs
I copied a bad form of this check from the c front-end this updates it to ensure the rhs is an INTEGER_CST and the lhs needs checked in the first place. Fixes Rust-GCC#3664 gcc/rust/ChangeLog: * rust-gcc.cc (arithmetic_or_logical_expression): Ensure this is an integer gcc/testsuite/ChangeLog: * rust/compile/issue-3664.rs: New test. Signed-off-by: Philip Herron <herron.philip@googlemail.com>
-rw-r--r--gcc/rust/rust-gcc.cc1
-rw-r--r--gcc/testsuite/rust/compile/issue-3664.rs5
2 files changed, 6 insertions, 0 deletions
diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust-gcc.cc
index 524cee7..990c786 100644
--- a/gcc/rust/rust-gcc.cc
+++ b/gcc/rust/rust-gcc.cc
@@ -1109,6 +1109,7 @@ arithmetic_or_logical_expression (ArithmeticOrLogicalOperator op, tree left,
rust_error_at (location, "division by zero");
}
else if (op == ArithmeticOrLogicalOperator::LEFT_SHIFT
+ && TREE_CODE (right) == INTEGER_CST
&& (compare_tree_int (right, TYPE_PRECISION (TREE_TYPE (ret))) >= 0))
{
rust_error_at (location, "left shift count >= width of type");
diff --git a/gcc/testsuite/rust/compile/issue-3664.rs b/gcc/testsuite/rust/compile/issue-3664.rs
new file mode 100644
index 0000000..c52a758
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-3664.rs
@@ -0,0 +1,5 @@
+const ARR: [usize; 1] = [2];
+
+pub fn l8() {
+ let _ = 5 << ARR[0];
+}