aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Guenther <rguenther@suse.de>2012-04-24 14:41:49 +0000
committerRichard Biener <rguenth@gcc.gnu.org>2012-04-24 14:41:49 +0000
commit46b380a23b6504fe3c5747673e8897debc42a633 (patch)
tree4b9ea22a269724c869170efef0a0f07ed2c07444
parent05232ff6d394e04a2d78c718363d5f910d796f04 (diff)
downloadgcc-46b380a23b6504fe3c5747673e8897debc42a633.zip
gcc-46b380a23b6504fe3c5747673e8897debc42a633.tar.gz
gcc-46b380a23b6504fe3c5747673e8897debc42a633.tar.bz2
re PR tree-optimization/53085 (writes to volatile struct members is missing)
2012-04-24 Richard Guenther <rguenther@suse.de> PR tree-optimization/53085 * tree-ssa-pre.c (eliminate): Do not eliminate volatile redundant stores. * g++.dg/torture/pr53085.C: New testcase. From-SVN: r186764
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/torture/pr53085.C17
-rw-r--r--gcc/tree-ssa-pre.c1
4 files changed, 29 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 86dc9c7..27a67a5 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,11 @@
2012-04-24 Richard Guenther <rguenther@suse.de>
+ PR tree-optimization/53085
+ * tree-ssa-pre.c (eliminate): Do not eliminate volatile redundant
+ stores.
+
+2012-04-24 Richard Guenther <rguenther@suse.de>
+
* tree-if-conv.c (main_tree_if_conversion): Move bb under
ENABLE_CHECKING.
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9205f42..646a150 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2012-04-24 Richard Guenther <rguenther@suse.de>
+
+ PR tree-optimization/53085
+ * g++.dg/torture/pr53085.C: New testcase.
+
2012-04-24 Andrew Pinski <apinski@cavium.com>
PR tree-opt/33512
diff --git a/gcc/testsuite/g++.dg/torture/pr53085.C b/gcc/testsuite/g++.dg/torture/pr53085.C
new file mode 100644
index 0000000..9ee29fe
--- /dev/null
+++ b/gcc/testsuite/g++.dg/torture/pr53085.C
@@ -0,0 +1,17 @@
+// { dg-do compile }
+// { dg-skip-if "" { *-*-* } { "-fno-fat-lto-objects" } { "" } }
+// { dg-options "-fdump-tree-optimized" }
+
+class aa{
+ void f();
+private:
+ volatile int a;
+};
+
+void aa::f(){
+ a=1;
+ a=1;
+}
+
+// { dg-final { scan-tree-dump-times "a ={v} 1;" 2 "optimized" } }
+// { dg-final { cleanup-tree-dump "optimized" } }
diff --git a/gcc/tree-ssa-pre.c b/gcc/tree-ssa-pre.c
index 5e6f570..e3e55ef 100644
--- a/gcc/tree-ssa-pre.c
+++ b/gcc/tree-ssa-pre.c
@@ -4409,6 +4409,7 @@ eliminate (void)
has the same value number as its rhs. If so, the store is
dead. */
else if (gimple_assign_single_p (stmt)
+ && !gimple_has_volatile_ops (stmt)
&& !is_gimple_reg (gimple_assign_lhs (stmt))
&& (TREE_CODE (rhs) == SSA_NAME
|| is_gimple_min_invariant (rhs)))