aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Pinski <apinski@marvell.com>2023-02-09 16:03:54 +0100
committerJakub Jelinek <jakub@redhat.com>2023-02-09 16:03:54 +0100
commit44f308e59bfa0f93ae05b17e257d8563c12399fd (patch)
treef0c6f8c0a79eeffdd41ae52b8ef4b224324a4bec
parentac2949574da9a668daad421d7edb79f172f73c6f (diff)
downloadgcc-44f308e59bfa0f93ae05b17e257d8563c12399fd.zip
gcc-44f308e59bfa0f93ae05b17e257d8563c12399fd.tar.gz
gcc-44f308e59bfa0f93ae05b17e257d8563c12399fd.tar.bz2
match.pd: When simplifying BFR of an insert, require a mode precision integral type [PR108688]
The same problem as PR 88739 has crept in but this time in match.pd when simplifying bit_field_ref of an bit_insert. That is we are generating a BIT_FIELD_REF of a non-mode-precision integral type. PR tree-optimization/108688 * match.pd (bit_field_ref [bit_insert]): Avoid generating BIT_FIELD_REFs of non-mode-precision integral operands. * gcc.c-torture/compile/pr108688-1.c: New test.
-rw-r--r--gcc/match.pd4
-rw-r--r--gcc/testsuite/gcc.c-torture/compile/pr108688-1.c15
2 files changed, 18 insertions, 1 deletions
diff --git a/gcc/match.pd b/gcc/match.pd
index f605b79..73e5053 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -7474,7 +7474,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
isize = tree_to_uhwi (TYPE_SIZE (TREE_TYPE (@1)));
}
(switch
- (if (wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos))
+ (if ((!INTEGRAL_TYPE_P (TREE_TYPE (@1))
+ || type_has_mode_precision_p (TREE_TYPE (@1)))
+ && wi::leu_p (wi::to_wide (@ipos), wi::to_wide (@rpos))
&& wi::leu_p (wi::to_wide (@rpos) + wi::to_wide (@rsize),
wi::to_wide (@ipos) + isize))
(BIT_FIELD_REF @1 @rsize { wide_int_to_tree (bitsizetype,
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c b/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c
new file mode 100644
index 0000000..43d782d
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/compile/pr108688-1.c
@@ -0,0 +1,15 @@
+
+
+union U { signed int d : 7; signed int e : 2; } u;
+int a, b;
+
+void
+foo (void)
+{
+ for (int i = 0; i < 64; i++)
+ {
+ u.d = a;
+ u.e ^= b;
+ }
+}
+