aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHarald Anlauf <anlauf@gmx.de>2023-03-22 19:20:41 +0100
committerHarald Anlauf <anlauf@gmx.de>2023-03-22 19:20:41 +0100
commit3e791f45ded89626bc1f9f8013728f6e035801b2 (patch)
tree8043092897ba8bab6da376996e5f3f640413b426
parentf2e70da638b4f6ba868ff07ab2123cad4fd9fd02 (diff)
downloadgcc-3e791f45ded89626bc1f9f8013728f6e035801b2.zip
gcc-3e791f45ded89626bc1f9f8013728f6e035801b2.tar.gz
gcc-3e791f45ded89626bc1f9f8013728f6e035801b2.tar.bz2
Fortran: improve checking of FINAL subroutine arguments [PR104572]
gcc/fortran/ChangeLog: PR fortran/104572 * resolve.cc (gfc_resolve_finalizers): Argument of a FINAL subroutine cannot be an alternate return. gcc/testsuite/ChangeLog: PR fortran/104572 * gfortran.dg/pr104572.f90: New test. Co-authored-by: Steven G. Kargl <kargl@gcc.gnu.org>
-rw-r--r--gcc/fortran/resolve.cc7
-rw-r--r--gcc/testsuite/gfortran.dg/pr104572.f9014
2 files changed, 21 insertions, 0 deletions
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 1a03e45..f6ec76a 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -13986,6 +13986,13 @@ gfc_resolve_finalizers (gfc_symbol* derived, bool *finalizable)
}
arg = dummy_args->sym;
+ if (!arg)
+ {
+ gfc_error ("Argument of FINAL procedure at %L must be of type %qs",
+ &list->proc_sym->declared_at, derived->name);
+ goto error;
+ }
+
if (arg->as && arg->as->type == AS_ASSUMED_RANK
&& ((list != derived->f2k_derived->finalizers) || list->next))
{
diff --git a/gcc/testsuite/gfortran.dg/pr104572.f90 b/gcc/testsuite/gfortran.dg/pr104572.f90
new file mode 100644
index 0000000..59fd688
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr104572.f90
@@ -0,0 +1,14 @@
+! { dg-do compile }
+! { dg-additional-options "-w" }
+! PR fortran/104572 - ICE in gfc_resolve_finalizers
+! Contributed by G. Steinmetz
+
+module m
+ type t
+ contains
+ final :: s
+ end type
+contains
+ subroutine s(*) ! { dg-error "Argument of FINAL procedure" }
+ end
+end