diff options
| author | Arthur Cohen <arthur.cohen@embecosm.com> | 2022-10-11 11:39:15 +0200 |
|---|---|---|
| committer | Arthur Cohen <arthur.cohen@embecosm.com> | 2022-10-11 15:55:41 +0200 |
| commit | 3dc104bc8aaf3edf7aa59b11efacdd9349054df7 (patch) | |
| tree | 090dd8fcb2b9fd183bcfa91dd4a55feef4811ea9 | |
| parent | 5346330e869e7230164b14e04e18b0d74e80901a (diff) | |
| download | gcc-3dc104bc8aaf3edf7aa59b11efacdd9349054df7.zip gcc-3dc104bc8aaf3edf7aa59b11efacdd9349054df7.tar.gz gcc-3dc104bc8aaf3edf7aa59b11efacdd9349054df7.tar.bz2 | |
rust-ast-resolve-item: Add note about resolving glob uses
| -rw-r--r-- | gcc/rust/resolve/rust-ast-resolve-item.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/gcc/rust/resolve/rust-ast-resolve-item.cc b/gcc/rust/resolve/rust-ast-resolve-item.cc index 0c38f28..7f45161 100644 --- a/gcc/rust/resolve/rust-ast-resolve-item.cc +++ b/gcc/rust/resolve/rust-ast-resolve-item.cc @@ -968,6 +968,14 @@ ResolveItem::visit (AST::UseDeclaration &use_item) { auto to_resolve = flatten_use_dec_to_paths (use_item); + // FIXME: I think this does not actually resolve glob use-decls and is going + // the wrong way about it. RFC #1560 specifies the following: + // + // > When we find a glob import, we have to record a 'back link', so that when + // a public name is added for the supplying module, we can add it for the + // importing module. + // + // Which is the opposite of what we're doing if I understand correctly? for (auto &path : to_resolve) ResolvePath::go (&path); } |