aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2021-08-06 12:32:01 -0700
committerH.J. Lu <hjl.tools@gmail.com>2021-08-09 21:41:35 -0700
commit3d7ccbc1efbd475031a9a4a6110c531f71fbf631 (patch)
tree0161a6c4b497a2dec9b32bb14801f336cd26b141
parent813ccbe9d272cd67a8f075beea280de95f807492 (diff)
downloadgcc-3d7ccbc1efbd475031a9a4a6110c531f71fbf631.zip
gcc-3d7ccbc1efbd475031a9a4a6110c531f71fbf631.tar.gz
gcc-3d7ccbc1efbd475031a9a4a6110c531f71fbf631.tar.bz2
x86: Optimize load of const FP all bits set vectors
Check float_vector_all_ones_operand for vector floating-point modes to optimize load of const floating-point all bits set vectors. gcc/ PR target/101804 * config/i386/constraints.md (BC): Document for integer SSE constant all bits set operand. (BF): New constraint for const floating-point all bits set vectors. * config/i386/i386.c (standard_sse_constant_p): Likewise. (standard_sse_constant_opcode): Likewise. * config/i386/sse.md (sseconstm1): New mode attribute. (mov<mode>_internal): Replace BC with <sseconstm1>. gcc/testsuite/ PR target/101804 * gcc.target/i386/avx2-gather-2.c: Pass -march=skylake instead of "-mavx2 -mtune=skylake". Scan vpcmpeqd.
-rw-r--r--gcc/config/i386/constraints.md10
-rw-r--r--gcc/config/i386/i386.c11
-rw-r--r--gcc/config/i386/sse.md11
-rw-r--r--gcc/testsuite/gcc.target/i386/avx2-gather-2.c3
4 files changed, 29 insertions, 6 deletions
diff --git a/gcc/config/i386/constraints.md b/gcc/config/i386/constraints.md
index 4aa28a5..87cceac 100644
--- a/gcc/config/i386/constraints.md
+++ b/gcc/config/i386/constraints.md
@@ -166,7 +166,8 @@
;; s Sibcall memory operand, not valid for TARGET_X32
;; w Call memory operand, not valid for TARGET_X32
;; z Constant call address operand.
-;; C SSE constant operand.
+;; C Integer SSE constant with all bits set operand.
+;; F Floating-point SSE constant with all bits set operand.
(define_constraint "Bf"
"@internal Flags register operand."
@@ -216,11 +217,16 @@
(match_operand 0 "constant_call_address_operand"))
(define_constraint "BC"
- "@internal SSE constant -1 operand."
+ "@internal integer SSE constant with all bits set operand."
(and (match_test "TARGET_SSE")
(ior (match_test "op == constm1_rtx")
(match_operand 0 "vector_all_ones_operand"))))
+(define_constraint "BF"
+ "@internal floating-point SSE constant with all bits set operand."
+ (and (match_test "TARGET_SSE")
+ (match_operand 0 "float_vector_all_ones_operand")))
+
;; Integer constant constraints.
(define_constraint "Wb"
"Integer constant in the range 0 @dots{} 7, for 8-bit shifts."
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index aea224a..4d4ab6a 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -5073,7 +5073,11 @@ standard_sse_constant_p (rtx x, machine_mode pred_mode)
if (x == const0_rtx || const0_operand (x, mode))
return 1;
- if (x == constm1_rtx || vector_all_ones_operand (x, mode))
+ if (x == constm1_rtx
+ || vector_all_ones_operand (x, mode)
+ || ((GET_MODE_CLASS (mode) == MODE_VECTOR_FLOAT
+ || GET_MODE_CLASS (pred_mode) == MODE_VECTOR_FLOAT)
+ && float_vector_all_ones_operand (x, mode)))
{
/* VOIDmode integer constant, get mode from the predicate. */
if (mode == VOIDmode)
@@ -5171,7 +5175,10 @@ standard_sse_constant_opcode (rtx_insn *insn, rtx *operands)
gcc_unreachable ();
}
}
- else if (x == constm1_rtx || vector_all_ones_operand (x, mode))
+ else if (x == constm1_rtx
+ || vector_all_ones_operand (x, mode)
+ || (GET_MODE_CLASS (mode) == MODE_VECTOR_FLOAT
+ && float_vector_all_ones_operand (x, mode)))
{
enum attr_mode insn_mode = get_attr_mode (insn);
diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 45b1ec2..2b0d10e 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -784,6 +784,15 @@
(V4SF "V4SF") (V2DF "V2DF")
(TI "TI")])
+;; SSE constant -1 constraint
+(define_mode_attr sseconstm1
+ [(V64QI "BC") (V32HI "BC") (V16SI "BC") (V8DI "BC") (V4TI "BC")
+ (V32QI "BC") (V16HI "BC") (V8SI "BC") (V4DI "BC") (V2TI "BC")
+ (V16QI "BC") (V8HI "BC") (V4SI "BC") (V2DI "BC") (V1TI "BC")
+ (V16SF "BF") (V8DF "BF")
+ (V8SF "BF") (V4DF "BF")
+ (V4SF "BF") (V2DF "BF")])
+
;; Mapping of vector modes to corresponding mask size
(define_mode_attr avx512fmaskmode
[(V64QI "DI") (V32QI "SI") (V16QI "HI")
@@ -1063,7 +1072,7 @@
[(set (match_operand:VMOVE 0 "nonimmediate_operand"
"=v,v ,v ,m")
(match_operand:VMOVE 1 "nonimmediate_or_sse_const_operand"
- " C,BC,vm,v"))]
+ " C,<sseconstm1>,vm,v"))]
"TARGET_SSE
&& (register_operand (operands[0], <MODE>mode)
|| register_operand (operands[1], <MODE>mode))"
diff --git a/gcc/testsuite/gcc.target/i386/avx2-gather-2.c b/gcc/testsuite/gcc.target/i386/avx2-gather-2.c
index 1a704af..ad5ef73 100644
--- a/gcc/testsuite/gcc.target/i386/avx2-gather-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx2-gather-2.c
@@ -1,6 +1,7 @@
/* { dg-do compile } */
-/* { dg-options "-O3 -mavx2 -fdump-tree-vect-details -mtune=skylake" } */
+/* { dg-options "-O3 -fdump-tree-vect-details -march=skylake" } */
#include "avx2-gather-1.c"
/* { dg-final { scan-tree-dump-times "vectorized 1 loops in function" 16 "vect" } } */
+/* { dg-final { scan-assembler "vpcmpeqd" } } */