diff options
| author | Mike Stump <mikestump@comcast.net> | 2010-03-22 23:13:10 +0000 |
|---|---|---|
| committer | Mike Stump <mrs@gcc.gnu.org> | 2010-03-22 23:13:10 +0000 |
| commit | 212066e660034c73cdeffc6120b03a0938afcb53 (patch) | |
| tree | b7179fef7508abaffda8ff48ecb0c485d36365a7 | |
| parent | cc72bbaac742dd66ce5aaa9791a20903cdbac3ec (diff) | |
| download | gcc-212066e660034c73cdeffc6120b03a0938afcb53.zip gcc-212066e660034c73cdeffc6120b03a0938afcb53.tar.gz gcc-212066e660034c73cdeffc6120b03a0938afcb53.tar.bz2 | |
re PR target/23071 (Darwin alignment ignores "attribute packed" for first 'double' element of a struct)
PR target/23071
* config/rs6000/rs6000.c (darwin_rs6000_special_round_type_align):
Don't overly align based upon packed packed fields.
From-SVN: r157654
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/config/rs6000/rs6000.c | 3 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/powerpc/darwin-abi-12.c | 14 |
3 files changed, 23 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f8515cd..e1bd54a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2010-03-22 Mike Stump <mikestump@comcast.net> + + PR target/23071 + * config/rs6000/rs6000.c (darwin_rs6000_special_round_type_align): + Don't overly align based upon packed packed fields. + 2010-03-22 Jason Merrill <jason@redhat.com> * c-pretty-print.c (pp_c_specifier_qualifier_list) [VECTOR_TYPE]: diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index dea0271..ab48e82 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -4653,6 +4653,9 @@ darwin_rs6000_special_round_type_align (tree type, unsigned int computed, field = TREE_CHAIN (field); if (! field) break; + /* A packed field does not contribute any extra alignment. */ + if (DECL_PACKED (field)) + return align; type = TREE_TYPE (field); while (TREE_CODE (type) == ARRAY_TYPE) type = TREE_TYPE (type); diff --git a/gcc/testsuite/gcc.target/powerpc/darwin-abi-12.c b/gcc/testsuite/gcc.target/powerpc/darwin-abi-12.c new file mode 100644 index 0000000..d02c486 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/darwin-abi-12.c @@ -0,0 +1,14 @@ +/* { dg-do compile { target powerpc*-*-darwin* } } */ +/* { dg-final { scan-assembler ".comm _x,12,2" } } */ +/* { dg-final { scan-assembler-not ".space 7" } } */ +/* PR 23071 */ + +struct Test { + double D __attribute__((packed,aligned(4))); + short X; +} x; + +struct { + char x; + struct Test t; +} b = { 1, { 2, 3 } }; |