diff options
| author | Richard Biener <rguenther@suse.de> | 2023-10-30 13:17:11 +0100 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2023-11-17 08:53:51 +0100 |
| commit | 1bcb7fe60544bba8b88028f9ffa062336d399664 (patch) | |
| tree | fb4d7a9d2ee5a3826b3206a6e5e2647557ea1a97 | |
| parent | 37183018134049a70482a59b8f12180946ab8fa4 (diff) | |
| download | gcc-1bcb7fe60544bba8b88028f9ffa062336d399664.zip gcc-1bcb7fe60544bba8b88028f9ffa062336d399664.tar.gz gcc-1bcb7fe60544bba8b88028f9ffa062336d399664.tar.bz2 | |
Assert we don't create recursive DW_AT_{abstract_origin,specification}
We have a support case that shows GCC 7 sometimes creates
DW_TAG_label refering to itself via a DW_AT_abstract_origin
when using LTO. This for example triggers the sanity check
added below during LTO bootstrap.
Making this check cover more than just DW_AT_abstract_origin
breaks bootstrap on trunk for
/* GNU extension: Record what type our vtable lives in. */
if (TYPE_VFIELD (type))
{
tree vtype = DECL_FCONTEXT (TYPE_VFIELD (type));
gen_type_die (vtype, context_die);
add_AT_die_ref (type_die, DW_AT_containing_type,
lookup_type_die (vtype));
so the check is for now restricted to DW_AT_abstract_origin
and DW_AT_specification both of which we follow within get_AT.
* dwarf2out.cc (add_AT_die_ref): Assert we do not add
a self-ref DW_AT_abstract_origin or DW_AT_specification.
| -rw-r--r-- | gcc/dwarf2out.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc index 9850d09..d187be9 100644 --- a/gcc/dwarf2out.cc +++ b/gcc/dwarf2out.cc @@ -4908,6 +4908,9 @@ add_AT_die_ref (dw_die_ref die, enum dwarf_attribute attr_kind, dw_die_ref targ_ { dw_attr_node attr; gcc_checking_assert (targ_die != NULL); + gcc_assert (targ_die != die + || (attr_kind != DW_AT_abstract_origin + && attr_kind != DW_AT_specification)); /* With LTO we can end up trying to reference something we didn't create a DIE for. Avoid crashing later on a NULL referenced DIE. */ |