diff options
| author | Bernd Edlinger <bernd.edlinger@hotmail.de> | 2018-07-23 13:23:51 +0000 |
|---|---|---|
| committer | Bernd Edlinger <edlinger@gcc.gnu.org> | 2018-07-23 13:23:51 +0000 |
| commit | 1544db9a61b6a441be68c5a6ba2504a6ccc2b956 (patch) | |
| tree | 9e2db6ef58a14073413f15b8f6c894ed5815d787 | |
| parent | a353fec45af2c09f8e3c849ac8f00e7342600019 (diff) | |
| download | gcc-1544db9a61b6a441be68c5a6ba2504a6ccc2b956.zip gcc-1544db9a61b6a441be68c5a6ba2504a6ccc2b956.tar.gz gcc-1544db9a61b6a441be68c5a6ba2504a6ccc2b956.tar.bz2 | |
re PR c/86617 (Volatile qualifier is ignored sometimes for unsigned char)
gcc:
2018-07-23 Bernd Edlinger <bernd.edlinger@hotmail.de>
PR c/86617
* genmatch.c (dt_operand::gen_match_op): Avoid folding volatile values.
testsuite:
2018-07-23 Bernd Edlinger <bernd.edlinger@hotmail.de>
PR c/86617
* gcc.dg/pr86617.c: New test.
From-SVN: r262933
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/genmatch.c | 10 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr86617.c | 11 |
4 files changed, 27 insertions, 4 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2cbe833..3f4283f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2018-07-23 Bernd Edlinger <bernd.edlinger@hotmail.de> + PR c/86617 + * genmatch.c (dt_operand::gen_match_op): Avoid folding volatile values. + +2018-07-23 Bernd Edlinger <bernd.edlinger@hotmail.de> + * gimple-fold.c (gimple_fold_builtin_printf): Don't create a not NUL terminated STRING_CST object. diff --git a/gcc/genmatch.c b/gcc/genmatch.c index 5d6cf0b..5848722 100644 --- a/gcc/genmatch.c +++ b/gcc/genmatch.c @@ -2748,12 +2748,14 @@ dt_operand::gen_match_op (FILE *f, int indent, const char *opname, bool) char match_opname[20]; match_dop->get_name (match_opname); if (value_match) - fprintf_indent (f, indent, "if (%s == %s || operand_equal_p (%s, %s, 0))\n", - opname, match_opname, opname, match_opname); + fprintf_indent (f, indent, "if ((%s == %s && ! TREE_SIDE_EFFECTS (%s)) " + "|| operand_equal_p (%s, %s, 0))\n", + opname, match_opname, opname, opname, match_opname); else - fprintf_indent (f, indent, "if (%s == %s || (operand_equal_p (%s, %s, 0) " + fprintf_indent (f, indent, "if ((%s == %s && ! TREE_SIDE_EFFECTS (%s)) " + "|| (operand_equal_p (%s, %s, 0) " "&& types_match (%s, %s)))\n", - opname, match_opname, opname, match_opname, + opname, match_opname, opname, opname, match_opname, opname, match_opname); fprintf_indent (f, indent + 2, "{\n"); return 1; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b5e2a54..5e6b8eb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-07-23 Bernd Edlinger <bernd.edlinger@hotmail.de> + + PR c/86617 + * gcc.dg/pr86617.c: New test. + 2018-07-23 Jakub Jelinek <jakub@redhat.com> PR c++/86569 diff --git a/gcc/testsuite/gcc.dg/pr86617.c b/gcc/testsuite/gcc.dg/pr86617.c new file mode 100644 index 0000000..72135e2 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr86617.c @@ -0,0 +1,11 @@ +/* { dg-options "-Os -fdump-rtl-final" } */ + +volatile unsigned char u8; + +void test (void) +{ + u8 = u8 + u8; + u8 = u8 - u8; +} + +/* { dg-final { scan-rtl-dump-times "mem/v" 6 "final" } } */ |