aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Stubbs <ams@codesourcery.com>2020-06-02 14:41:21 +0100
committerAndrew Stubbs <ams@codesourcery.com>2020-06-02 15:35:56 +0100
commitd3b6767dce45a7100e4cc32d2986a55f09a2cce2 (patch)
tree2f8f0b8e8f26b8b3c8b4b20eb3006ebb7753f085
parent4b6dcfd542aed2d14a0bcd2bee116d0779cc1d48 (diff)
downloadgcc-d3b6767dce45a7100e4cc32d2986a55f09a2cce2.zip
gcc-d3b6767dce45a7100e4cc32d2986a55f09a2cce2.tar.gz
gcc-d3b6767dce45a7100e4cc32d2986a55f09a2cce2.tar.bz2
amdgcn: Remove -mlocal-symbol-id option
This patch removes the obsolete -mlocal-symbol-id option. This was used to control mangling of local symbol names in order to work around a ROCm runtime bug, but that has not been needed in some time, and the mangling was removed already. gcc/ChangeLog: * config/gcn/gcn-hsa.h (CC1_SPEC): Delete. * config/gcn/gcn.opt (-mlocal-symbol-id): Delete. * config/gcn/mkoffload.c (main): Don't use -mlocal-symbol-id. gcc/testsuite/ChangeLog: * gcc.dg/intermod-1.c: Don't use -mlocal-symbol-id.
-rw-r--r--gcc/config/gcn/gcn-hsa.h10
-rw-r--r--gcc/config/gcn/gcn.opt3
-rw-r--r--gcc/config/gcn/mkoffload.c11
-rw-r--r--gcc/testsuite/gcc.dg/intermod-1.c1
4 files changed, 2 insertions, 23 deletions
diff --git a/gcc/config/gcn/gcn-hsa.h b/gcc/config/gcn/gcn-hsa.h
index d6523cf..2eaf414 100644
--- a/gcc/config/gcn/gcn-hsa.h
+++ b/gcc/config/gcn/gcn-hsa.h
@@ -79,16 +79,6 @@ extern unsigned int gcn_local_sym_hash (const char *name);
#define ASM_SPEC "-triple=amdgcn--amdhsa -mattr=-code-object-v3 " \
"%:last_arg(%{march=*:-mcpu=%*}) " \
"-filetype=obj"
-/* Add -mlocal-symbol-id=<source-file-basename> unless the user (or mkoffload)
- passes the option explicitly on the command line. The option also causes
- several dump-matching tests to fail in the testsuite, so the option is not
- added when or tree dump/compare-debug options used in the testsuite are
- present.
- This has the potential for surprise, but a user can still use an explicit
- -mlocal-symbol-id=<whatever> option manually together with -fdump-tree or
- -fcompare-debug options. */
-#define CC1_SPEC "%{!mlocal-symbol-id=*:%{!fdump-tree-*:" \
- "%{!fdump-ipa-*:%{!fcompare-debug*:-mlocal-symbol-id=%b}}}}"
#define LINK_SPEC "--pie"
#define LIB_SPEC "-lc"
diff --git a/gcc/config/gcn/gcn.opt b/gcc/config/gcn/gcn.opt
index 04c73d6..e1b9942 100644
--- a/gcc/config/gcn/gcn.opt
+++ b/gcc/config/gcn/gcn.opt
@@ -70,9 +70,6 @@ mstack-size=
Target Report RejectNegative Joined UInteger Var(stack_size_opt) Init(-1)
-mstack-size=<number> Set the private segment size per wave-front, in bytes.
-mlocal-symbol-id=
-Target RejectNegative Report JoinedOrMissing Var(local_symbol_id) Init(0)
-
Wopenacc-dims
Target Var(warn_openacc_dims) Warning
Warn about invalid OpenACC dimensions.
diff --git a/gcc/config/gcn/mkoffload.c b/gcc/config/gcn/mkoffload.c
index 723da10..4a99d70 100644
--- a/gcc/config/gcn/mkoffload.c
+++ b/gcc/config/gcn/mkoffload.c
@@ -524,7 +524,7 @@ main (int argc, char **argv)
FILE *in = stdin;
FILE *out = stdout;
FILE *cfile = stdout;
- const char *outname = 0, *offloadsrc = 0;
+ const char *outname = 0;
progname = "mkoffload";
diagnostic_initialize (global_dc, 0);
@@ -653,18 +653,11 @@ main (int argc, char **argv)
if (!strcmp (argv[ix], "-o") && ix + 1 != argc)
outname = argv[++ix];
else
- {
- obstack_ptr_grow (&cc_argv_obstack, argv[ix]);
-
- if (argv[ix][0] != '-')
- offloadsrc = argv[ix];
- }
+ obstack_ptr_grow (&cc_argv_obstack, argv[ix]);
}
obstack_ptr_grow (&cc_argv_obstack, "-o");
obstack_ptr_grow (&cc_argv_obstack, gcn_s1_name);
- obstack_ptr_grow (&cc_argv_obstack,
- concat ("-mlocal-symbol-id=", offloadsrc, NULL));
obstack_ptr_grow (&cc_argv_obstack, NULL);
const char **cc_argv = XOBFINISH (&cc_argv_obstack, const char **);
diff --git a/gcc/testsuite/gcc.dg/intermod-1.c b/gcc/testsuite/gcc.dg/intermod-1.c
index 44a8ce0..9f8d19d 100644
--- a/gcc/testsuite/gcc.dg/intermod-1.c
+++ b/gcc/testsuite/gcc.dg/intermod-1.c
@@ -1,5 +1,4 @@
/* { dg-do compile } */
-/* { dg-additional-options "-mlocal-symbol-id=" { target amdgcn-*-* } } */
/* { dg-final { scan-assembler-not {foo[1-9]\.[0-9]} } } */
/* Check that we don't get .0 suffixes on static variables when not using