diff options
author | Thomas Schwinge <tschwinge@baylibre.com> | 2025-01-13 09:11:19 +0100 |
---|---|---|
committer | Thomas Schwinge <tschwinge@baylibre.com> | 2025-01-13 10:13:17 +0100 |
commit | c0c47fc89ddcc3b1fbb0e5f3040fc52d93ca0be0 (patch) | |
tree | ba2224c20875000cc1d3b4d475007c6d0e212489 | |
parent | 017c45fa2a4da40893f0aacd96164f04c78cb245 (diff) | |
download | gcc-c0c47fc89ddcc3b1fbb0e5f3040fc52d93ca0be0.zip gcc-c0c47fc89ddcc3b1fbb0e5f3040fc52d93ca0be0.tar.gz gcc-c0c47fc89ddcc3b1fbb0e5f3040fc52d93ca0be0.tar.bz2 |
Un-XFAIL 'dg-note's in 'gfortran.dg/goacc/routine-external-level-of-parallelism-2.f'
As of the recent commit 65286465b94cba6ee3d59edbc771bef0088ac46e
"Fortran: Fix location_t in gfc_get_extern_function_decl; [...]" change:
The declaration created by gfc_get_extern_function_decl used input_location
as DECL_SOURCE_LOCATION, which gave rather odd results with 'declared here'
diagnostic. - It is much more useful to use the gfc_symbol's declated_at,
which this commit now does.
..., we're no longer using the 'dg-bogus' location informations, as pointed out
for one class of additional notes of
'gfortran.dg/goacc/routine-external-level-of-parallelism-2.f', once added in
commit 03eb779141a29f96600cd46904b88a33c4b49a66 "Add 'dg-note', 'dg-lto-note'".
Therefore, un-XFAILed 'dg-note's rather than XFAILed 'dg-bogus'es.
gcc/testsuite/
* gfortran.dg/goacc/routine-external-level-of-parallelism-2.f:
Un-XFAIL 'dg-note's.
-rw-r--r-- | gcc/testsuite/gfortran.dg/goacc/routine-external-level-of-parallelism-2.f | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/gcc/testsuite/gfortran.dg/goacc/routine-external-level-of-parallelism-2.f b/gcc/testsuite/gfortran.dg/goacc/routine-external-level-of-parallelism-2.f index 91898b1..35f67cb 100644 --- a/gcc/testsuite/gfortran.dg/goacc/routine-external-level-of-parallelism-2.f +++ b/gcc/testsuite/gfortran.dg/goacc/routine-external-level-of-parallelism-2.f @@ -7,12 +7,13 @@ integer, parameter :: n = 100 integer :: a(n), i, j external :: gangr, workerr, vectorr, seqr -! { dg-bogus "note: routine 'gangr' declared here" "TODO1" { xfail { ! offloading_enabled } } .-1 } -! { dg-bogus "note: routine 'gangr_' declared here" "TODO2" { xfail offloading_enabled } .-2 } -! { dg-bogus "note: routine 'workerr' declared here" "TODO1" { xfail { ! offloading_enabled } } .-3 } -! { dg-bogus "note: routine 'workerr_' declared here" "TODO2" { xfail offloading_enabled } .-4 } -! { dg-bogus "note: routine 'vectorr' declared here" "TODO1" { xfail { ! offloading_enabled } } .-5 } -! { dg-bogus "note: routine 'vectorr_' declared here" "TODO2" { xfail offloading_enabled } .-6 } +! { dg-note "routine 'gangr' declared here" "" { target { ! offloading_enabled } } .-1 } +! { dg-note "routine 'gangr_' declared here" "" { target offloading_enabled } .-2 } +! { dg-note "routine 'workerr' declared here" "" { target { ! offloading_enabled } } .-3 } +! { dg-note "routine 'workerr_' declared here" "" { target offloading_enabled } .-4 } +! { dg-note "routine 'vectorr' declared here" "" { target { ! offloading_enabled } } .-5 } +! { dg-note "routine 'vectorr_' declared here" "" { target offloading_enabled } .-6 } +!TODO See PR101551 for 'offloading_enabled' differences. !$acc routine (gangr) gang !$acc routine (workerr) worker @@ -200,12 +201,13 @@ integer, parameter :: n = 100 integer :: a(n), i, j integer, external :: gangf, workerf, vectorf, seqf -! { dg-bogus "note: routine 'gangf' declared here" "TODO1" { xfail { ! offloading_enabled } } .-1 } -! { dg-bogus "note: routine 'gangf_' declared here" "TODO2" { xfail offloading_enabled } .-2 } -! { dg-bogus "note: routine 'workerf' declared here" "TODO1" { xfail { ! offloading_enabled } } .-3 } -! { dg-bogus "note: routine 'workerf_' declared here" "TODO2" { xfail offloading_enabled } .-4 } -! { dg-bogus "note: routine 'vectorf' declared here" "TODO1" { xfail { ! offloading_enabled } } .-5 } -! { dg-bogus "note: routine 'vectorf_' declared here" "TODO2" { xfail offloading_enabled } .-6 } +! { dg-note "routine 'gangf' declared here" "" { target { ! offloading_enabled } } .-1 } +! { dg-note "routine 'gangf_' declared here" "" { target offloading_enabled } .-2 } +! { dg-note "routine 'workerf' declared here" "" { target { ! offloading_enabled } } .-3 } +! { dg-note "routine 'workerf_' declared here" "" { target offloading_enabled } .-4 } +! { dg-note "routine 'vectorf' declared here" "" { target { ! offloading_enabled } } .-5 } +! { dg-note "routine 'vectorf_' declared here" "" { target offloading_enabled } .-6 } +!TODO See PR101551 for 'offloading_enabled' differences. !$acc routine (gangf) gang !$acc routine (workerf) worker |