aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Wakely <jwakely@redhat.com>2023-08-16 21:46:05 +0100
committerJonathan Wakely <jwakely@redhat.com>2023-08-17 08:42:45 +0100
commit91315f23ba127ea4d1a584023bae34e143f6eb8c (patch)
tree395b28fa0b36ebbd6e387621335ac8980fa1af94
parentc6259c4975e84b30d7de1f64afaece614d7c4500 (diff)
downloadgcc-91315f23ba127ea4d1a584023bae34e143f6eb8c.zip
gcc-91315f23ba127ea4d1a584023bae34e143f6eb8c.tar.gz
gcc-91315f23ba127ea4d1a584023bae34e143f6eb8c.tar.bz2
libstdc++: Fix testsuite no_pch directive
The { dg-add-options no_pch } directive is supposed to add a macro definition that invalidates the PCH file, and ensures that the #include directives in the test file are processed as written. But the proc that adds the options actually removes all existing options, cancelling out any previous dg-options directive. This means that using no_pch will cause FAILs in a file that relies on other options set by an earlier dg-options. The no_pch directive was added for PR libstdc++/21769 where Janis suggested adding it as return "$flags -D__GLIBCXX__=99999999" but what was actually committed didn't include the $flags so replaced them. Additionally, using no_pch only prevents the precompiled version of <bits/stdc++.h> from being included, it doesn't prevent the non-precompiled version being included by -include bits/stdc++.h in the test flags. Use regsub to filter that out of the options as well. libstdc++-v3/ChangeLog: * testsuite/lib/dg-options.exp (add_options_for_no_pch): Remove any "-include bits/stdc++.h" from options and add the macro to the existing options instead of replacing them.
-rw-r--r--libstdc++-v3/testsuite/lib/dg-options.exp4
1 files changed, 3 insertions, 1 deletions
diff --git a/libstdc++-v3/testsuite/lib/dg-options.exp b/libstdc++-v3/testsuite/lib/dg-options.exp
index 73c1552..15e34f8 100644
--- a/libstdc++-v3/testsuite/lib/dg-options.exp
+++ b/libstdc++-v3/testsuite/lib/dg-options.exp
@@ -269,8 +269,10 @@ proc dg-require-target-fs-lwt { args } {
}
proc add_options_for_no_pch { flags } {
+ # Remove any inclusion of bits/stdc++.h from the options.
+ regsub -all -- "-include bits/stdc...h" $flags "" flags
# This forces any generated and possibly included PCH to be invalid.
- return "-D__GLIBCXX__=99999999"
+ return "$flags -D__GLIBCXX__=99999999"
}
# Add to FLAGS all the target-specific flags needed for networking.