aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCostas Argyris <costas.argyris@gmail.com>2023-03-28 11:29:06 +0100
committerJonathan Yong <10walls@gmail.com>2023-03-28 12:03:08 +0000
commite70e36cbef4f01e7d32bafe17698c3bf3e4624b8 (patch)
treefa076d2d31f2a2518d196fd39398b5ec6835da86
parentfcb411564a655a01f759eea3bb16bfd1bc879bfd (diff)
downloadgcc-e70e36cbef4f01e7d32bafe17698c3bf3e4624b8.zip
gcc-e70e36cbef4f01e7d32bafe17698c3bf3e4624b8.tar.gz
gcc-e70e36cbef4f01e7d32bafe17698c3bf3e4624b8.tar.bz2
mingw: Fix comments in x-mingw32-utf8
This is a comment-only change that I should have done with the previous commit (304c7d44a) but forgot to do so. gcc/ChangeLog: * config/i386/x-mingw32-utf8: update comments. Signed-off-by: Jonathan Yong <10walls@gmail.com>
-rw-r--r--gcc/config/i386/x-mingw32-utf814
1 files changed, 9 insertions, 5 deletions
diff --git a/gcc/config/i386/x-mingw32-utf8 b/gcc/config/i386/x-mingw32-utf8
index cf5c3db..2783dd2 100644
--- a/gcc/config/i386/x-mingw32-utf8
+++ b/gcc/config/i386/x-mingw32-utf8
@@ -17,15 +17,15 @@
# <http://www.gnu.org/licenses/>.
#
#
-# For 64-bit Windows host, embed a manifest that sets the active
+# For mingw Windows hosts, embed a manifest that sets the active
# code page of the driver and compiler proper processes to utf8.
-# This only has an effect on Windows version 1903 (May 2019 Update)
-# or later.
+# This only has an effect when gcc is hosted on Windows version
+# 1903 (May 2019 Update) or later.
# The resource .rc file references the utf8 .manifest file.
# Compile it into an object file using windres.
# The resulting .o file gets added to host_extra_gcc_objs in
-# config.host for x86_64-*-mingw* host and gets linked into
+# config.host for mingw hosts and gets linked into
# the driver as a .o file, so it's lack of symbols is OK.
utf8rc-mingw32.o : $(srcdir)/config/i386/utf8-mingw32.rc \
$(srcdir)/config/i386/winnt-utf8.manifest
@@ -39,7 +39,7 @@ sym-mingw32.o : $(srcdir)/config/i386/sym-mingw32.cc
# Combine the two object files into one which has both the
# compiled utf8 resource and the HOST_EXTRA_OBJS_SYMBOL symbol.
# The resulting .o file gets added to host_extra_objs in
-# config.host for x86_64-*-mingw* host and gets archived into
+# config.host for mingw hosts and gets archived into
# libbackend.a which gets linked into the compiler proper.
# If nothing references it into libbackend.a, it will not
# get linked into the compiler proper eventually.
@@ -54,4 +54,8 @@ utf8-mingw32.o : utf8rc-mingw32.o sym-mingw32.o
# This is expected because the resource object is not supposed
# to have any symbols, it just has to be linked into the
# executable in order for Windows to use the utf8 code page.
+# Some build environments are passing these flags to other
+# programs as well, so make the symbol definition optional
+# such that these programs don't fail to build when they
+# don't find it.
$(COMPILERS) : override LDFLAGS += -Wl,--undefined=HOST_EXTRA_OBJS_SYMBOL