diff options
| author | Tom de Vries <tom@codesourcery.com> | 2016-04-08 09:41:16 +0000 |
|---|---|---|
| committer | Tom de Vries <vries@gcc.gnu.org> | 2016-04-08 09:41:16 +0000 |
| commit | 9f1b833bc3f28a3000f2ce8c076a1930f44bcda9 (patch) | |
| tree | 5a65edb3ea9f9c4597781900b7df7918894ad136 | |
| parent | bae7adda10c0e1d813ebb602a719ca66ff16fae9 (diff) | |
| download | gcc-9f1b833bc3f28a3000f2ce8c076a1930f44bcda9.zip gcc-9f1b833bc3f28a3000f2ce8c076a1930f44bcda9.tar.gz gcc-9f1b833bc3f28a3000f2ce8c076a1930f44bcda9.tar.bz2 | |
Remove incorrect warning for parallel implicit firstprivate clause
2016-04-08 Tom de Vries <tom@codesourcery.com>
* omp-low.c (lower_omp_target): Set TREE_NO_WARNING for oacc
implicit firstprivate clause.
* c-c++-common/goacc/uninit-firstprivate-clause.c: New test.
* gfortran.dg/goacc/uninit-firstprivate-clause.f95: New test.
From-SVN: r234826
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/omp-low.c | 7 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c | 25 | ||||
| -rw-r--r-- | gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95 | 18 |
5 files changed, 59 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7fe1c42..158f4cc 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2016-04-08 Tom de Vries <tom@codesourcery.com> + + * omp-low.c (lower_omp_target): Set TREE_NO_WARNING for oacc + implicit firstprivate clause. + 2016-04-08 Kyrylo Tkachov <kyrylo.tkachov@arm.com> PR target/70566 diff --git a/gcc/omp-low.c b/gcc/omp-low.c index 979926d..7105194 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -16077,7 +16077,12 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) { gcc_assert (is_gimple_omp_oacc (ctx->stmt)); if (!is_reference (var)) - var = build_fold_addr_expr (var); + { + if (is_gimple_reg (var) + && OMP_CLAUSE_FIRSTPRIVATE_IMPLICIT (c)) + TREE_NO_WARNING (var) = 1; + var = build_fold_addr_expr (var); + } else talign = TYPE_ALIGN_UNIT (TREE_TYPE (TREE_TYPE (ovar))); gimplify_assign (x, var, &ilist); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 2668b0d..6ca2610 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-04-08 Tom de Vries <tom@codesourcery.com> + + * c-c++-common/goacc/uninit-firstprivate-clause.c: New test. + * gfortran.dg/goacc/uninit-firstprivate-clause.f95: New test. + 2016-04-08 Kyrylo Tkachov <kyrylo.tkachov@arm.com> PR target/70566 diff --git a/gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c b/gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c new file mode 100644 index 0000000..2584033 --- /dev/null +++ b/gcc/testsuite/c-c++-common/goacc/uninit-firstprivate-clause.c @@ -0,0 +1,25 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-Wuninitialized" } */ + +void +foo (void) +{ + int i; + +#pragma acc parallel + { + i = 1; + } +} + + +void +foo2 (void) +{ + int i; + +#pragma acc parallel firstprivate (i) /* { dg-warning "is used uninitialized in this function" } */ + { + i = 1; + } +} diff --git a/gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95 b/gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95 new file mode 100644 index 0000000..14d960a --- /dev/null +++ b/gcc/testsuite/gfortran.dg/goacc/uninit-firstprivate-clause.f95 @@ -0,0 +1,18 @@ +! { dg-do compile } +! { dg-additional-options "-Wuninitialized" } + +subroutine test + INTEGER :: i + + !$acc parallel + i = 1 + !$acc end parallel +end subroutine test + +subroutine test2 + INTEGER :: i + + !$acc parallel firstprivate (i) ! { dg-warning "is used uninitialized in this function" } + i = 1 + !$acc end parallel +end subroutine test2 |