diff options
| author | 0xn4utilus <gyanendrabanjare8@gmail.com> | 2024-02-14 22:19:15 +0530 |
|---|---|---|
| committer | Arthur Cohen <arthur.cohen@embecosm.com> | 2024-02-21 13:51:26 +0100 |
| commit | e7c1948fbccfff72fe2c25e962528b398123bfb3 (patch) | |
| tree | 83c699ad5e577db8fdebd92bffe59dc95f077b00 | |
| parent | cdd76382414191134e0dabcc2c9f66f1df5472e7 (diff) | |
| download | gcc-e7c1948fbccfff72fe2c25e962528b398123bfb3.zip gcc-e7c1948fbccfff72fe2c25e962528b398123bfb3.tar.gz gcc-e7c1948fbccfff72fe2c25e962528b398123bfb3.tar.bz2 | |
gccrs: Add variadic check on function params
gcc/rust/ChangeLog:
* checks/errors/rust-ast-validation.cc (ASTValidation::visit):
Add variadic check on all parameters.
gcc/testsuite/ChangeLog:
* rust/compile/issue-2850.rs: New test.
Signed-off-by: 0xn4utilus <gyanendrabanjare8@gmail.com>
| -rw-r--r-- | gcc/rust/checks/errors/rust-ast-validation.cc | 12 | ||||
| -rw-r--r-- | gcc/testsuite/rust/compile/issue-2850.rs | 17 |
2 files changed, 25 insertions, 4 deletions
diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index d57b7cb..fcba57d 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -132,10 +132,14 @@ ASTValidation::visit (AST::Function &function) rust_error_at (function.get_locus (), "free function without a body"); } - if (function.is_variadic ()) - rust_error_at ( - function.get_function_params ().back ()->get_locus (), - "only foreign or %<unsafe extern \"C\"%> functions may be C-variadic"); + auto &function_params = function.get_function_params (); + for (auto it = function_params.begin (); it != function_params.end (); it++) + { + if (it->get ()->is_variadic ()) + rust_error_at (it->get ()->get_locus (), + "only foreign or %<unsafe extern \"C\"%> functions may " + "be C-variadic"); + } AST::ContextualASTVisitor::visit (function); } diff --git a/gcc/testsuite/rust/compile/issue-2850.rs b/gcc/testsuite/rust/compile/issue-2850.rs new file mode 100644 index 0000000..62cbe0f --- /dev/null +++ b/gcc/testsuite/rust/compile/issue-2850.rs @@ -0,0 +1,17 @@ +fn myfun0(...,_:i32) {} +// { dg-error "only foreign or .unsafe extern \"C\". functions may be C-variadic" "" { target *-*-* } .-1 } + +fn myfun1(a:i32,...,_:i32) {} +// { dg-error "only foreign or .unsafe extern \"C\". functions may be C-variadic" "" { target *-*-* } .-1 } + +struct z { + x: f64, + y: f64, +} + +impl z { + fn new(x: f64, ..., y: f64) -> z { + // { dg-error "only foreign or .unsafe extern \"C\". functions may be C-variadic" "" { target *-*-* } .-1 } + z { x: x, y: y } + } +}
\ No newline at end of file |