diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2024-02-10 12:52:23 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2024-02-10 12:52:23 +0100 |
| commit | d10c0dce53b2f1435fb66a570f15310baef5172d (patch) | |
| tree | 45cc6287fc3048a0e294c44eab7f8970b1f51eef | |
| parent | 1e87fcf200897b64ca428c8ef80c3ad876828caf (diff) | |
| download | gcc-d10c0dce53b2f1435fb66a570f15310baef5172d.zip gcc-d10c0dce53b2f1435fb66a570f15310baef5172d.tar.gz gcc-d10c0dce53b2f1435fb66a570f15310baef5172d.tar.bz2 | |
lower-bitint: Fix up .{ADD,SUB}_OVERFLOW lowering
torture/bitint-37.c test FAILed on i686-linux e.g. on
signed _BitInt(575) + unsigned _BitInt(575) -> signed _BitInt(575)
__builtin_add_overflow. With 64-bit limbs, we use 4 .UADDC calls in
the IL, 2 in a loop (which handles the first 8 limbs), then one partial
limb (we use 63 bits from that) and finally last_ovf case due to the
mixing of signed vs. unsigned.
But with 32-bit limbs, we use 5 .UADDC calls in the IL, 2 in a loop (which
handles the first 16 limbs), then one full limb above that, one partial
(31 bits) and finally last_ovf case, and for the last_ovf case the code
computed incorrect idx and so partly did the wrong thing, e.g. overwrote
the result from the previous .UADDC.
Fixed thusly.
2024-02-10 Jakub Jelinek <jakub@redhat.com>
* gimple-lower-bitint.cc (itint_large_huge::lower_addsub_overflow): Fix
computation of idx for i == 4 of bitint_prec_huge.
| -rw-r--r-- | gcc/gimple-lower-bitint.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gcc/gimple-lower-bitint.cc b/gcc/gimple-lower-bitint.cc index e29d831..caa33e0 100644 --- a/gcc/gimple-lower-bitint.cc +++ b/gcc/gimple-lower-bitint.cc @@ -4031,7 +4031,7 @@ bitint_large_huge::lower_addsub_overflow (tree obj, gimple *stmt) if (kind != bitint_prec_huge) idx = size_int (i); else if (i >= 2) - idx = size_int (fin + (i > 2)); + idx = size_int (fin + i - 2); if (!last_ovf || i < cnt - 1) { if (type0 != TREE_TYPE (arg0)) |