diff options
author | Jason Merrill <jason@redhat.com> | 2023-03-23 16:50:09 -0400 |
---|---|---|
committer | Jason Merrill <jason@redhat.com> | 2023-03-23 17:38:29 -0400 |
commit | c4792bd1de0621932a47fb86aca09fafafdb2972 (patch) | |
tree | f6d57832dfe5d9b6f4f015331245cecac41c42bc | |
parent | 3fbeff66684d95417646aaa22d0a8f1ec9786299 (diff) | |
download | gcc-c4792bd1de0621932a47fb86aca09fafafdb2972.zip gcc-c4792bd1de0621932a47fb86aca09fafafdb2972.tar.gz gcc-c4792bd1de0621932a47fb86aca09fafafdb2972.tar.bz2 |
c++: constexpr PMF conversion [PR105996]
Here, we were calling build_reinterpret_cast regardless of whether there was
actually a cast, and that now sets REINTERPRET_CAST_P. But that
optimization seems dodgy anyway, as it involves NOP_EXPR from one
RECORD_TYPE to another and we try to reserve NOP_EXPR for fundamental types.
And the generated code seems the same, so let's drop it. And also strip
location wrappers.
PR c++/105996
gcc/cp/ChangeLog:
* typeck.cc (build_ptrmemfunc): Drop 0-offset optimization
and location wrappers.
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/constexpr-pmf3.C: New test.
-rw-r--r-- | gcc/cp/typeck.cc | 13 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C | 13 |
2 files changed, 18 insertions, 8 deletions
diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc index afb9560..8b60cbb 100644 --- a/gcc/cp/typeck.cc +++ b/gcc/cp/typeck.cc @@ -9960,18 +9960,15 @@ build_ptrmemfunc (tree type, tree pfn, int force, bool c_cast_p, if (n == error_mark_node) return error_mark_node; + STRIP_ANY_LOCATION_WRAPPER (pfn); + /* We don't have to do any conversion to convert a pointer-to-member to its own type. But, we don't want to just return a PTRMEM_CST if there's an explicit cast; that cast should make the expression an invalid template argument. */ - if (TREE_CODE (pfn) != PTRMEM_CST) - { - if (same_type_p (to_type, pfn_type)) - return pfn; - else if (integer_zerop (n) && TREE_CODE (pfn) != CONSTRUCTOR) - return build_reinterpret_cast (input_location, to_type, pfn, - complain); - } + if (TREE_CODE (pfn) != PTRMEM_CST + && same_type_p (to_type, pfn_type)) + return pfn; if (TREE_SIDE_EFFECTS (pfn)) pfn = save_expr (pfn); diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C new file mode 100644 index 0000000..14daea3 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-pmf3.C @@ -0,0 +1,13 @@ +// PR c++/105996 +// { dg-do compile { target c++11 } } + +struct A { + void CB() {} +}; +struct B : public A { }; + +using APMF = void (A::*)(); +using BPMF = void (B::*)(); + +constexpr APMF foo () { return &A::CB; }; +static constexpr BPMF b = foo(); |