aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Merrill <jason@redhat.com>2023-09-22 12:10:11 +0100
committerJason Merrill <jason@redhat.com>2023-09-22 14:00:05 +0100
commit9c62af101e11e1cce573c2b3d2e18b403412dbc8 (patch)
tree40172974d61a22eb8b507eef7a71c9a2f78b95b9
parent4c496020764057453415f1ae599950724ec0e871 (diff)
downloadgcc-9c62af101e11e1cce573c2b3d2e18b403412dbc8.zip
gcc-9c62af101e11e1cce573c2b3d2e18b403412dbc8.tar.gz
gcc-9c62af101e11e1cce573c2b3d2e18b403412dbc8.tar.bz2
c++: unroll pragma in templates [PR111529]
We were failing to handle ANNOTATE_EXPR in tsubst_copy_and_build, leading to problems with substitution of any wrapped expressions. Let's also not tell users that lambda templates are available in C++14. PR c++/111529 gcc/cp/ChangeLog: * parser.cc (cp_parser_lambda_declarator_opt): Don't suggest -std=c++14 for lambda templates. * pt.cc (tsubst_expr): Move ANNOTATE_EXPR handling... (tsubst_copy_and_build): ...here. gcc/testsuite/ChangeLog: * g++.dg/ext/unroll-4.C: New test.
-rw-r--r--gcc/cp/parser.cc7
-rw-r--r--gcc/cp/pt.cc14
-rw-r--r--gcc/testsuite/g++.dg/ext/unroll-4.C16
3 files changed, 25 insertions, 12 deletions
diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
index 0e1cbbf..f3abae7 100644
--- a/gcc/cp/parser.cc
+++ b/gcc/cp/parser.cc
@@ -11695,11 +11695,8 @@ cp_parser_lambda_declarator_opt (cp_parser* parser, tree lambda_expr)
an opening angle if present. */
if (cp_lexer_next_token_is (parser->lexer, CPP_LESS))
{
- if (cxx_dialect < cxx14)
- pedwarn (parser->lexer->next_token->location, OPT_Wc__14_extensions,
- "lambda templates are only available with "
- "%<-std=c++14%> or %<-std=gnu++14%>");
- else if (pedantic && cxx_dialect < cxx20)
+ if (cxx_dialect < cxx20
+ && (pedantic || cxx_dialect < cxx14))
pedwarn (parser->lexer->next_token->location, OPT_Wc__20_extensions,
"lambda templates are only available with "
"%<-std=c++20%> or %<-std=gnu++20%>");
diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc
index 9b100e1..ea53790 100644
--- a/gcc/cp/pt.cc
+++ b/gcc/cp/pt.cc
@@ -19913,13 +19913,6 @@ tsubst_expr (tree t, tree args, tsubst_flags_t complain, tree in_decl)
templated_operator_saved_lookups (t),
complain));
- case ANNOTATE_EXPR:
- tmp = RECUR (TREE_OPERAND (t, 0));
- RETURN (build3_loc (EXPR_LOCATION (t), ANNOTATE_EXPR,
- TREE_TYPE (tmp), tmp,
- RECUR (TREE_OPERAND (t, 1)),
- RECUR (TREE_OPERAND (t, 2))));
-
case PREDICT_EXPR:
RETURN (add_stmt (copy_node (t)));
@@ -21868,6 +21861,13 @@ tsubst_copy_and_build (tree t,
RETURN (op);
}
+ case ANNOTATE_EXPR:
+ op1 = RECUR (TREE_OPERAND (t, 0));
+ RETURN (build3_loc (EXPR_LOCATION (t), ANNOTATE_EXPR,
+ TREE_TYPE (op1), op1,
+ RECUR (TREE_OPERAND (t, 1)),
+ RECUR (TREE_OPERAND (t, 2))));
+
default:
/* Handle Objective-C++ constructs, if appropriate. */
{
diff --git a/gcc/testsuite/g++.dg/ext/unroll-4.C b/gcc/testsuite/g++.dg/ext/unroll-4.C
new file mode 100644
index 0000000..d488aca
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/unroll-4.C
@@ -0,0 +1,16 @@
+// PR c++/111529
+// { dg-do compile { target c++11 } }
+// { dg-additional-options -Wno-c++20-extensions }
+
+template <int>
+void f() {
+ []<int>() {
+ #pragma GCC unroll 9
+ for (int i = 1; i; --i) {
+ }
+ };
+}
+
+int main() {
+ f<0>();
+}