diff options
| author | Kyrylo Tkachov <kyrylo.tkachov@arm.com> | 2023-05-24 09:33:04 +0100 |
|---|---|---|
| committer | Kyrylo Tkachov <kyrylo.tkachov@arm.com> | 2023-05-24 09:33:04 +0100 |
| commit | 95542a6ec4b350c653b793b7c36a8210b0e9a89d (patch) | |
| tree | 673eb4029bfaa24e2a6f020d2179cdeae143a93b | |
| parent | ec40410d98e57fc6650241d4e05119a1f0af6a41 (diff) | |
| download | gcc-95542a6ec4b350c653b793b7c36a8210b0e9a89d.zip gcc-95542a6ec4b350c653b793b7c36a8210b0e9a89d.tar.gz gcc-95542a6ec4b350c653b793b7c36a8210b0e9a89d.tar.bz2 | |
arm: PR target/109939 Correct signedness of return type of __ssat intrinsics
As the PR says we shouldn't be using qualifier_unsigned for the return type of the __ssat intrinsics.
UNSIGNED_SAT_BINOP_UNSIGNED_IMM_QUALIFIERS already exists for that.
This was just a thinko.
This patch fixes this and the warning with -Wconversion goes away.
Bootstrapped and tested on arm-none-linux-gnueabihf.
gcc/ChangeLog:
PR target/109939
* config/arm/arm-builtins.cc (SAT_BINOP_UNSIGNED_IMM_QUALIFIERS): Use
qualifier_none for the return operand.
gcc/testsuite/ChangeLog:
PR target/109939
* gcc.target/arm/pr109939.c: New test.
| -rw-r--r-- | gcc/config/arm/arm-builtins.cc | 2 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/arm/pr109939.c | 14 |
2 files changed, 15 insertions, 1 deletions
diff --git a/gcc/config/arm/arm-builtins.cc b/gcc/config/arm/arm-builtins.cc index d0c5740..36365e4 100644 --- a/gcc/config/arm/arm-builtins.cc +++ b/gcc/config/arm/arm-builtins.cc @@ -97,7 +97,7 @@ arm_binop_imm_qualifiers[SIMD_MAX_BUILTIN_ARGS] /* T (T, unsigned immediate). */ static enum arm_type_qualifiers arm_sat_binop_imm_qualifiers[SIMD_MAX_BUILTIN_ARGS] - = { qualifier_unsigned, qualifier_none, qualifier_unsigned_immediate }; + = { qualifier_none, qualifier_none, qualifier_unsigned_immediate }; #define SAT_BINOP_UNSIGNED_IMM_QUALIFIERS \ (arm_sat_binop_imm_qualifiers) diff --git a/gcc/testsuite/gcc.target/arm/pr109939.c b/gcc/testsuite/gcc.target/arm/pr109939.c new file mode 100644 index 0000000..aafda7c --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr109939.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target arm_sat_ok } */ +/* { dg-add-options arm_sat } */ +/* { dg-additional-options "-O -Wall -Wconversion" } */ + +#include <arm_acle.h> + +int dbg_ssat_out; +int dbg_ssat_in; + +void test_arm_ssat(void) +{ + dbg_ssat_out = __ssat(dbg_ssat_in, 16); +} |