aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Wakely <jwakely@redhat.com>2021-08-11 22:11:19 +0100
committerJonathan Wakely <jwakely@redhat.com>2021-08-11 23:39:34 +0100
commit93f1dbc7cdcc4b31ea4061efb4c2acf2d4f81eb8 (patch)
tree9d6b82308d1dc545c306af1fe79dbcde90f0a0fc
parent873273449a944d7796d08ce6fae06eabcab7bf65 (diff)
downloadgcc-93f1dbc7cdcc4b31ea4061efb4c2acf2d4f81eb8.zip
gcc-93f1dbc7cdcc4b31ea4061efb4c2acf2d4f81eb8.tar.gz
gcc-93f1dbc7cdcc4b31ea4061efb4c2acf2d4f81eb8.tar.bz2
libstdc++: Fix test that fails randomly [PR101866]
This test assumes that the same sequence of three values cannot occur, which is incorect. It's unlikely, but not impossible. Perform the check in a loop, so that in the unlikely event of an identical sequence, we retry. If the library code is buggy it will keep producing the same sequence and the test will time out. If the code is working correctly then we will usually break out of the loop after one iteration, or very rarely after two or three. libstdc++-v3/ChangeLog: PR libstdc++/101866 * testsuite/experimental/random/randint.cc: Loop and retry if reseed() produces the same sequence.
-rw-r--r--libstdc++-v3/testsuite/experimental/random/randint.cc18
1 files changed, 9 insertions, 9 deletions
diff --git a/libstdc++-v3/testsuite/experimental/random/randint.cc b/libstdc++-v3/testsuite/experimental/random/randint.cc
index d6225eb..e05151e 100644
--- a/libstdc++-v3/testsuite/experimental/random/randint.cc
+++ b/libstdc++-v3/testsuite/experimental/random/randint.cc
@@ -34,7 +34,7 @@ test01()
}
std::experimental::reseed(99u);
- const long n1[] = {
+ const int n1[] = {
std::experimental::randint(0, 100),
std::experimental::randint(0, 100),
std::experimental::randint(0, 100),
@@ -42,7 +42,7 @@ test01()
std::experimental::randint(0, 100)
};
std::experimental::reseed(99u);
- const long n2[] = {
+ const int n2[] = {
std::experimental::randint(0, 100),
std::experimental::randint(0, 100),
std::experimental::randint(0, 100),
@@ -52,13 +52,13 @@ test01()
for (int i = 0; i < 5; ++i)
VERIFY( n1[i] == n2[i] );
- std::experimental::reseed();
- const long n3[] = {
- std::experimental::randint(0, 100),
- std::experimental::randint(0, 100),
- std::experimental::randint(0, 100)
- };
- VERIFY( !(n3[0] == n1[0] && n3[1] == n1[1] && n3[2] == n1[2]) );
+ do
+ {
+ std::experimental::reseed();
+ }
+ while (std::experimental::randint(0, 100) == n1[0]
+ && std::experimental::randint(0, 100) == n1[1]
+ && std::experimental::randint(0, 100) == n1[2]);
}
void