diff options
| author | Aldy Hernandez <aldyh@redhat.com> | 2024-03-19 16:35:41 +0100 |
|---|---|---|
| committer | Aldy Hernandez <aldyh@redhat.com> | 2024-04-28 21:03:00 +0200 |
| commit | 92f74ee21218cab08d7bb7769004a65e8a291fa3 (patch) | |
| tree | 83e5ced8e77461c49893f496006117abac3bf378 | |
| parent | d883fc7d00ed6bf5ee151de4fd3e05431582bd5f (diff) | |
| download | gcc-92f74ee21218cab08d7bb7769004a65e8a291fa3.zip gcc-92f74ee21218cab08d7bb7769004a65e8a291fa3.tar.gz gcc-92f74ee21218cab08d7bb7769004a65e8a291fa3.tar.bz2 | |
Verify that reading back from vrange_storage doesn't drop bits.
We have a sanity check in the irange storage code to make sure that
reading back a cache entry we have just written to yields exactly the
same range. There's no need to do this only for integers. This patch
moves the code to a more generic place.
However, doing so tickles a latent bug in the frange code where a
range is being pessimized from [0.0, 1.0] to [-0.0, 1.0]. Exclude
checking frange's until this bug is fixed.
gcc/ChangeLog:
* value-range-storage.cc (irange_storage::set_irange): Move
verification code from here...
(vrange_storage::set_vrange): ...to here.
| -rw-r--r-- | gcc/value-range-storage.cc | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/gcc/value-range-storage.cc b/gcc/value-range-storage.cc index f00474a..09a2977 100644 --- a/gcc/value-range-storage.cc +++ b/gcc/value-range-storage.cc @@ -165,6 +165,19 @@ vrange_storage::set_vrange (const vrange &r) } else gcc_unreachable (); + + // Verify that reading back from the cache didn't drop bits. + if (flag_checking + // FIXME: Avoid checking frange, as it currently pessimizes some ranges: + // + // gfortran.dg/pr49472.f90 pessimizes [0.0, 1.0] into [-0.0, 1.0]. + && !is_a <frange> (r) + && !r.undefined_p ()) + { + Value_Range tmp (r); + get_vrange (tmp, r.type ()); + gcc_checking_assert (tmp == r); + } } // Restore R from storage. @@ -306,13 +319,6 @@ irange_storage::set_irange (const irange &r) irange_bitmask bm = r.m_bitmask; write_wide_int (val, len, bm.value ()); write_wide_int (val, len, bm.mask ()); - - if (flag_checking) - { - int_range_max tmp; - get_irange (tmp, r.type ()); - gcc_checking_assert (tmp == r); - } } static inline void |