aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>2023-11-22 13:08:13 +0100
committerArthur Cohen <arthur.cohen@embecosm.com>2024-01-30 12:36:47 +0100
commit9279483f6e87258e36345c355720860925a75e3e (patch)
treedb8195fae3ff99fa5e755f37116d576d327b7c52
parentac501a75b263a7dd7fa437c01aae53d41e30a515 (diff)
downloadgcc-9279483f6e87258e36345c355720860925a75e3e.zip
gcc-9279483f6e87258e36345c355720860925a75e3e.tar.gz
gcc-9279483f6e87258e36345c355720860925a75e3e.tar.bz2
gccrs: Add AST validation check for const in trait
Add a new check in AST validation pass that checks that no function declaration in traits are declared const. gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Add const check. * checks/errors/rust-ast-validation.h: Add visit function prototype. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
-rw-r--r--gcc/rust/checks/errors/rust-ast-validation.cc10
-rw-r--r--gcc/rust/checks/errors/rust-ast-validation.h1
2 files changed, 11 insertions, 0 deletions
diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc
index 54276e8..2743eb0 100644
--- a/gcc/rust/checks/errors/rust-ast-validation.cc
+++ b/gcc/rust/checks/errors/rust-ast-validation.cc
@@ -118,6 +118,16 @@ ASTValidation::visit (AST::Function &function)
}
void
+ASTValidation::visit (AST::TraitFunctionDecl &decl)
+{
+ const auto &qualifiers = decl.get_qualifiers ();
+
+ if (context.back () == Context::TRAIT && qualifiers.is_const ())
+ rust_error_at (decl.get_identifier ().get_locus (), ErrorCode::E0379,
+ "functions in traits cannot be declared const");
+}
+
+void
ASTValidation::visit (AST::Trait &trait)
{
if (trait.is_auto ())
diff --git a/gcc/rust/checks/errors/rust-ast-validation.h b/gcc/rust/checks/errors/rust-ast-validation.h
index 01d923c..963357f 100644
--- a/gcc/rust/checks/errors/rust-ast-validation.h
+++ b/gcc/rust/checks/errors/rust-ast-validation.h
@@ -42,6 +42,7 @@ public:
virtual void visit (AST::Union &item);
virtual void visit (AST::Function &function);
virtual void visit (AST::Trait &trait);
+ virtual void visit (AST::TraitFunctionDecl &decl);
};
} // namespace Rust