aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarek Polacek <polacek@redhat.com>2018-03-23 13:45:49 +0000
committerMarek Polacek <mpolacek@gcc.gnu.org>2018-03-23 13:45:49 +0000
commit889a3a30d0aea481e3452b0f2e25d0c4657b2f21 (patch)
treefc1c62177a423979c20c5e60bee08115590ffda3
parent50531a2a1d82e41a39d0c85421b4e99802d6e349 (diff)
downloadgcc-889a3a30d0aea481e3452b0f2e25d0c4657b2f21.zip
gcc-889a3a30d0aea481e3452b0f2e25d0c4657b2f21.tar.gz
gcc-889a3a30d0aea481e3452b0f2e25d0c4657b2f21.tar.bz2
re PR c++/85045 (ICE+SIGILL on valid C++ code: cxx_pretty_printer::postfix_expression(tree_node*) (), at cp/cxx-pretty-print.c:482)
PR c++/85045 * c-pretty-print.c (c_pretty_printer::multiplicative_expression) <case RDIV_EXPR>: Tweak condition. * cxx-pretty-print.c (cxx_pretty_printer::multiplicative_expression): Handle EXACT_DIV_EXPR and RDIV_EXPR. Tweak condition. (cxx_pretty_printer::expression): Handle EXACT_DIV_EXPR and RDIV_EXPR. * g++.dg/cpp0x/Wnarrowing5.C: New test. * gcc.dg/pr85045.c: New test. From-SVN: r258804
-rw-r--r--gcc/c-family/ChangeLog6
-rw-r--r--gcc/c-family/c-pretty-print.c2
-rw-r--r--gcc/cp/ChangeLog7
-rw-r--r--gcc/cp/cxx-pretty-print.c6
-rw-r--r--gcc/testsuite/ChangeLog4
-rw-r--r--gcc/testsuite/g++.dg/cpp0x/Wnarrowing5.C11
-rw-r--r--gcc/testsuite/gcc.dg/pr85045.c9
7 files changed, 43 insertions, 2 deletions
diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index 25ed91f..f728311 100644
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,9 @@
+2018-03-23 Marek Polacek <polacek@redhat.com>
+
+ PR c++/85045
+ * c-pretty-print.c (c_pretty_printer::multiplicative_expression)
+ <case RDIV_EXPR>: Tweak condition.
+
2018-03-20 Eric Botcazou <ebotcazou@adacore.com>
* c-ada-spec.c (pp_ada_tree_identifier): Deal specifically with _Bool.
diff --git a/gcc/c-family/c-pretty-print.c b/gcc/c-family/c-pretty-print.c
index c9dd8ae..dc76c99 100644
--- a/gcc/c-family/c-pretty-print.c
+++ b/gcc/c-family/c-pretty-print.c
@@ -1841,7 +1841,7 @@ c_pretty_printer::multiplicative_expression (tree e)
pp_c_whitespace (this);
if (code == MULT_EXPR)
pp_c_star (this);
- else if (code == TRUNC_DIV_EXPR)
+ else if (code != TRUNC_MOD_EXPR)
pp_slash (this);
else
pp_modulo (this);
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index e04eae1..ddda091 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,10 @@
+2018-03-23 Marek Polacek <polacek@redhat.com>
+
+ PR c++/85045
+ * cxx-pretty-print.c (cxx_pretty_printer::multiplicative_expression):
+ Handle EXACT_DIV_EXPR and RDIV_EXPR. Tweak condition.
+ (cxx_pretty_printer::expression): Handle EXACT_DIV_EXPR and RDIV_EXPR.
+
2018-03-23 Ville Voutilainen <ville.voutilainen@gmail.com>
Implement P0962
diff --git a/gcc/cp/cxx-pretty-print.c b/gcc/cp/cxx-pretty-print.c
index ca99997..9a5545c 100644
--- a/gcc/cp/cxx-pretty-print.c
+++ b/gcc/cp/cxx-pretty-print.c
@@ -899,11 +899,13 @@ cxx_pretty_printer::multiplicative_expression (tree e)
case MULT_EXPR:
case TRUNC_DIV_EXPR:
case TRUNC_MOD_EXPR:
+ case EXACT_DIV_EXPR:
+ case RDIV_EXPR:
multiplicative_expression (TREE_OPERAND (e, 0));
pp_space (this);
if (code == MULT_EXPR)
pp_star (this);
- else if (code == TRUNC_DIV_EXPR)
+ else if (code != TRUNC_MOD_EXPR)
pp_slash (this);
else
pp_modulo (this);
@@ -1113,6 +1115,8 @@ cxx_pretty_printer::expression (tree t)
case MULT_EXPR:
case TRUNC_DIV_EXPR:
case TRUNC_MOD_EXPR:
+ case EXACT_DIV_EXPR:
+ case RDIV_EXPR:
multiplicative_expression (t);
break;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 88abac8..fe12bbe 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -3,6 +3,10 @@
PR c++/85033
* g++.dg/ext/builtin-offsetof2.C: New test.
+ PR c++/85045
+ * g++.dg/cpp0x/Wnarrowing5.C: New test.
+ * gcc.dg/pr85045.c: New test.
+
2018-03-23 Eric Botcazou <ebotcazou@adacore.com>
PR debug/85020
diff --git a/gcc/testsuite/g++.dg/cpp0x/Wnarrowing5.C b/gcc/testsuite/g++.dg/cpp0x/Wnarrowing5.C
new file mode 100644
index 0000000..d2abf03
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/Wnarrowing5.C
@@ -0,0 +1,11 @@
+// PR c++/85045
+// { dg-do compile { target c++11 } }
+
+typedef struct tt {
+ unsigned short h;
+} tt;
+
+void mainScreen(float a)
+{
+ tt numlrect = {int(100/a)}; // { dg-error "narrowing conversion" }
+}
diff --git a/gcc/testsuite/gcc.dg/pr85045.c b/gcc/testsuite/gcc.dg/pr85045.c
new file mode 100644
index 0000000..8c4a7aa
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr85045.c
@@ -0,0 +1,9 @@
+/* PR c/85045 */
+/* { dg-do compile } */
+/* { dg-options "-fno-diagnostics-show-caret" } */
+
+void
+f (double a, double b)
+{
+ (a / b) (); /* { dg-error "called object .a / b. is not a function or function pointer" } */
+}