aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuc Michel <lmichel@kalray.eu>2021-08-17 16:34:37 +0100
committerJonathan Wakely <jwakely@redhat.com>2021-08-17 16:54:44 +0100
commit817766f4dd2f6f3fdea2c4e6e22358b0b6b06d0d (patch)
tree6f61769a4f4f20b10f7a8122ca5b293b6ceaa63d
parent174f9257a75dec93221eca26c236e0a6346c9dfd (diff)
downloadgcc-817766f4dd2f6f3fdea2c4e6e22358b0b6b06d0d.zip
gcc-817766f4dd2f6f3fdea2c4e6e22358b0b6b06d0d.tar.gz
gcc-817766f4dd2f6f3fdea2c4e6e22358b0b6b06d0d.tar.bz2
libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target
This fixes an incorrect invocation of gdb on remote targets where DejaGNU would try to run host's gdb in remote target simulator. gdb-test skips the testing when target is remote or non native but the gdb version check function does not. Suggested-by: Jonathan Wakely <jwakely@redhat.com> Signed-off-by: Luc Michel <lmichel@kalray.eu> Co-authored-by: Marc Poulhies <mpoulhies@kalrayinc.com> libstdc++-v3/ChangeLog: * testsuite/lib/gdb-test.exp (gdb_version_check) (gdb_version_check_xmethods): Only check the GDB version for local native targets.
-rw-r--r--libstdc++-v3/testsuite/lib/gdb-test.exp4
1 files changed, 4 insertions, 0 deletions
diff --git a/libstdc++-v3/testsuite/lib/gdb-test.exp b/libstdc++-v3/testsuite/lib/gdb-test.exp
index af20c85..f993355 100644
--- a/libstdc++-v3/testsuite/lib/gdb-test.exp
+++ b/libstdc++-v3/testsuite/lib/gdb-test.exp
@@ -280,6 +280,8 @@ proc gdb_batch_check {command pattern} {
# but not earlier versions.
# Return 1 if the version is ok, 0 otherwise.
proc gdb_version_check {} {
+ if { ![isnative] || [is_remote target] } { return 0 }
+
return [gdb_batch_check "python print(gdb.lookup_global_symbol)" \
"<built-in function lookup_global_symbol>"]
}
@@ -288,6 +290,8 @@ proc gdb_version_check {} {
# in a manner similar to the check for a version of gdb which supports the
# pretty-printer tests below.
proc gdb_version_check_xmethods {} {
+ if { ![isnative] || [is_remote target] } { return 0 }
+
return [gdb_batch_check \
"python import gdb.xmethod; print(gdb.xmethod.XMethod)" \
"<class 'gdb\\.xmethod\\.XMethod'>"]