diff options
| author | Tom de Vries <tdevries@suse.de> | 2022-02-21 20:02:13 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2022-02-22 10:23:20 +0100 |
| commit | 6263b656c8fcfc6d7e1d2af55a88bc0429a4b352 (patch) | |
| tree | f80185f64e7855eff6e3f575b71675148d8094d1 | |
| parent | f0ae4257e3f939d186e9092e2b5724a9e3ce8ea6 (diff) | |
| download | gcc-6263b656c8fcfc6d7e1d2af55a88bc0429a4b352.zip gcc-6263b656c8fcfc6d7e1d2af55a88bc0429a4b352.tar.gz gcc-6263b656c8fcfc6d7e1d2af55a88bc0429a4b352.tar.bz2 | |
[libgomp, testsuite, nvptx] Fix pr96390.c without CUDA
When running the libgomp testsuite on x86_64 with nvptx accelerator, we run into:
...
XPASS: libgomp.c/../libgomp.c-c++-common/pr96390.c (test for excess errors)
FAIL: libgomp.c/../libgomp.c-c++-common/pr96390.c execution test
...
The problem is that we're expecting the following ptxas error:
...
XFAIL: libgomp.c/../libgomp.c-c++-common/pr96390.c (test for excess errors)
Excess errors:
ptxas /tmp/ccZYDw8N.o, line 90; error : Call to 'baz' requires call prototype
ptxas /tmp/ccZYDw8N.o, line 90; error : Unknown symbol 'baz'
...
But it's not triggered because ptxas is not in the path, so nvptx-none-as
defaults to --no-verify.
So instead, we run into the same error at execution time.
Fix this by forcing verification using:
...
/* { dg-additional-options "-foffload=-Wa,--verify" \
{ target offload_target_nvptx } } */
...
such that we run into the xfail in this way instead:
...
XFAIL: libgomp.c/../libgomp.c-c++-common/pr96390.c (test for excess errors)
Excess errors:
nvptx-as: error trying to exec 'ptxas': execvp: No such file or directory
nvptx-as: ptxas returned 255 exit status
...
Tested on x86_64-linux with nvptx accelerator.
libgomp/ChangeLog:
2022-02-21 Tom de Vries <tdevries@suse.de>
PR testsuite/104146
* testsuite/libgomp.c++/pr96390.C: Add additional-option
-foffload=-Wa,--verify for nvptx.
* testsuite/libgomp.c-c++-common/pr96390.c: Same.
| -rw-r--r-- | libgomp/testsuite/libgomp.c++/pr96390.C | 1 | ||||
| -rw-r--r-- | libgomp/testsuite/libgomp.c-c++-common/pr96390.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/libgomp/testsuite/libgomp.c++/pr96390.C b/libgomp/testsuite/libgomp.c++/pr96390.C index 8c770ec..1f3c3e0 100644 --- a/libgomp/testsuite/libgomp.c++/pr96390.C +++ b/libgomp/testsuite/libgomp.c++/pr96390.C @@ -1,4 +1,5 @@ /* { dg-additional-options "-O0 -fdump-tree-omplower" } */ +/* { dg-additional-options "-foffload=-Wa,--verify" { target offload_target_nvptx } } */ /* { dg-xfail-if "PR 97106/PR 97102 - .alias not (yet) supported for nvptx" { offload_target_nvptx } } */ #include <cstdlib> diff --git a/libgomp/testsuite/libgomp.c-c++-common/pr96390.c b/libgomp/testsuite/libgomp.c-c++-common/pr96390.c index 4fe09ce..b89f934 100644 --- a/libgomp/testsuite/libgomp.c-c++-common/pr96390.c +++ b/libgomp/testsuite/libgomp.c-c++-common/pr96390.c @@ -1,4 +1,5 @@ /* { dg-additional-options "-O0 -fdump-tree-omplower" } */ +/* { dg-additional-options "-foffload=-Wa,--verify" { target offload_target_nvptx } } */ /* { dg-require-alias "" } */ /* { dg-xfail-if "PR 97102/PR 97106 - .alias not (yet) supported for nvptx" { offload_target_nvptx } } */ |