diff options
| author | Mike Stump <mrs@apple.com> | 2006-08-15 18:01:19 +0000 |
|---|---|---|
| committer | Mike Stump <mrs@gcc.gnu.org> | 2006-08-15 18:01:19 +0000 |
| commit | 4adb785d4481822edd5350f38b3fd2d3bcbfddca (patch) | |
| tree | c67b6c012b86ed35cb28402e0f422833b7295e5f | |
| parent | d47e3adf1d1100661aa25c0668575c649a690b4a (diff) | |
| download | gcc-4adb785d4481822edd5350f38b3fd2d3bcbfddca.zip gcc-4adb785d4481822edd5350f38b3fd2d3bcbfddca.tar.gz gcc-4adb785d4481822edd5350f38b3fd2d3bcbfddca.tar.bz2 | |
re PR c/28280 (bogus "statement with no effect" warning with VLA and typeof)
PR c/28280
* c-parser.c (c_parser_typeof_specifier): Don't use
c_finish_expr_stmt, open code desired semantics instead.
From-SVN: r116163
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/c-parser.c | 14 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vla-9.c | 9 |
3 files changed, 28 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7caf088..218be97 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2006-07-15 Mike Stump <mrs@apple.com> + + PR c/28280 + * c-parser.c (c_parser_typeof_specifier): Don't use + c_finish_expr_stmt, open code desired semantics instead. + 2006-08-15 Nick Clifton <nickc@redhat.com> * config.gcc (x86-mingw32): Add a gthr-win32.h including makefile diff --git a/gcc/c-parser.c b/gcc/c-parser.c index 848da63..6e243df 100644 --- a/gcc/c-parser.c +++ b/gcc/c-parser.c @@ -2164,7 +2164,19 @@ c_parser_typeof_specifier (c_parser *parser) is evaluated, this can be evaluated. For now, we avoid evaluation when the context might. */ if (!skip_evaluation && was_vm) - c_finish_expr_stmt (expr.value); + { + tree e = expr.value; + + /* If the expression is not of a type to which we cannot assign a line + number, wrap the thing in a no-op NOP_EXPR. */ + if (DECL_P (e) || CONSTANT_CLASS_P (e)) + e = build1 (NOP_EXPR, void_type_node, e); + + if (EXPR_P (e)) + SET_EXPR_LOCATION (e, input_location); + + add_stmt (e); + } pop_maybe_used (was_vm); } c_parser_skip_until_found (parser, CPP_CLOSE_PAREN, "expected %<)%>"); diff --git a/gcc/testsuite/gcc.dg/vla-9.c b/gcc/testsuite/gcc.dg/vla-9.c new file mode 100644 index 0000000..0b623b3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vla-9.c @@ -0,0 +1,9 @@ +/* { dg-do compile } */ +/* { dg-options "-std=c99 -pedantic-errors -W -Wall" } */ +/* PR c/28280 */ + +void f(__SIZE_TYPE__ d) +{ + typedef int t[d]; + t *g = (__typeof (g)) d; +} |