aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Biener <rguenther@suse.de>2023-03-10 14:15:14 +0100
committerRichard Biener <rguenther@suse.de>2023-03-10 15:08:12 +0100
commit413ec1d12c50f8e2e6adb4de30482780bdfdeeb4 (patch)
treeba3903bf799f1192211ca0590f9f3bd8d4ddaa4f
parent649f1939baf11f45fd3579b8b9601c7840a097b3 (diff)
downloadgcc-413ec1d12c50f8e2e6adb4de30482780bdfdeeb4.zip
gcc-413ec1d12c50f8e2e6adb4de30482780bdfdeeb4.tar.gz
gcc-413ec1d12c50f8e2e6adb4de30482780bdfdeeb4.tar.bz2
Speedup PTA solving for call constraint sets
With calls we now often get contraints like callarg = *callarg + UNKNOWN or similar cases. The important thing to note is that this complex constraint changes the node solution itself, so when solving the node is marked as changed immediately again. When that happens it's profitable to iterate that self-cycle immediately so we maximize cache reuse and build up the successor graph quickly to get better topological ordering and reduce the number of iterations of the solving. For a testcase derived from ceph this reduces the time spent in PTA solving from 453s to 92s which is quite significant. * tree-ssa-structalias.cc (solve_graph): Immediately iterate self-cycles.
-rw-r--r--gcc/tree-ssa-structalias.cc15
1 files changed, 11 insertions, 4 deletions
diff --git a/gcc/tree-ssa-structalias.cc b/gcc/tree-ssa-structalias.cc
index 07e0fd6..c3c5bce 100644
--- a/gcc/tree-ssa-structalias.cc
+++ b/gcc/tree-ssa-structalias.cc
@@ -2775,8 +2775,15 @@ solve_graph (constraint_graph_t graph)
continue;
/* If the node has changed, we need to process the
- complex constraints and outgoing edges again. */
- if (bitmap_clear_bit (changed, i))
+ complex constraints and outgoing edges again. For complex
+ constraints that modify i itself, like the common group of
+ callarg = callarg + UNKNOWN;
+ callarg = *callarg + UNKNOWN;
+ *callarg = callescape;
+ make sure to iterate immediately because that maximizes
+ cache reuse and expands the graph quickest, leading to
+ better visitation order in the next iteration. */
+ while (bitmap_clear_bit (changed, i))
{
unsigned int j;
constraint_t c;
@@ -2794,7 +2801,7 @@ solve_graph (constraint_graph_t graph)
??? But we shouldn't ended up with "changed" set ... */
if (vi->oldsolution
&& bitmap_bit_p (vi->oldsolution, anything_id))
- continue;
+ break;
bitmap_copy (pts, get_varinfo (find (anything_id))->solution);
}
else if (vi->oldsolution)
@@ -2803,7 +2810,7 @@ solve_graph (constraint_graph_t graph)
bitmap_copy (pts, vi->solution);
if (bitmap_empty_p (pts))
- continue;
+ break;
if (vi->oldsolution)
bitmap_ior_into (vi->oldsolution, pts);