diff options
| author | Richard Biener <rguenther@suse.de> | 2023-10-16 12:54:28 +0200 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2023-10-17 08:23:33 +0200 |
| commit | 3aaf704bca3e01c72d9fe6de01ae5416dba6b5db (patch) | |
| tree | d4294cb3068c951ca3694e22b4d2c69eac039ed0 | |
| parent | 8eb9cdd142182aaa3ee39750924bc0a0491236c3 (diff) | |
| download | gcc-3aaf704bca3e01c72d9fe6de01ae5416dba6b5db.zip gcc-3aaf704bca3e01c72d9fe6de01ae5416dba6b5db.tar.gz gcc-3aaf704bca3e01c72d9fe6de01ae5416dba6b5db.tar.bz2 | |
tree-optimization/111807 - ICE in verify_sra_access_forest
The following addresses build_reconstructed_reference failing to
build references with a different offset than the models and thus
the caller conditional being off. This manifests when attempting
to build a ref with offset 160 from the model BIT_FIELD_REF <l_4827[9], 8, 0>
onto the same base l_4827 but the models offset being 288. This
cannot work for any kind of ref I can think of, not just with
BIT_FIELD_REFs.
PR tree-optimization/111807
* tree-sra.cc (build_ref_for_model): Only call
build_reconstructed_reference when the offsets are the same.
* gcc.dg/torture/pr111807.c: New testcase.
| -rw-r--r-- | gcc/testsuite/gcc.dg/torture/pr111807.c | 12 | ||||
| -rw-r--r-- | gcc/tree-sra.cc | 2 |
2 files changed, 13 insertions, 1 deletions
diff --git a/gcc/testsuite/gcc.dg/torture/pr111807.c b/gcc/testsuite/gcc.dg/torture/pr111807.c new file mode 100644 index 0000000..09fbdcf --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr111807.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ + +static struct A { + int x : 4; +} a; +static int b; +int main() +{ + struct A t[2]; + t[0] = b ? t[1] : a; + return (b ? t[1].x : 0) && 1; +} diff --git a/gcc/tree-sra.cc b/gcc/tree-sra.cc index 24d0c20..f8dff8b 100644 --- a/gcc/tree-sra.cc +++ b/gcc/tree-sra.cc @@ -1751,7 +1751,7 @@ build_ref_for_model (location_t loc, tree base, HOST_WIDE_INT offset, && !TREE_THIS_VOLATILE (base) && (TYPE_ADDR_SPACE (TREE_TYPE (base)) == TYPE_ADDR_SPACE (TREE_TYPE (model->expr))) - && offset <= model->offset + && offset == model->offset /* build_reconstructed_reference can still fail if we have already massaged BASE because of another type incompatibility. */ && (res = build_reconstructed_reference (loc, base, model))) |