diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2013-12-10 01:23:37 +0000 |
|---|---|---|
| committer | Joseph Myers <jsm28@gcc.gnu.org> | 2013-12-10 01:23:37 +0000 |
| commit | 3a4efce7c246b190ef35a8ce1f108f572274521f (patch) | |
| tree | 17fee4f3cb77d383b7ed61dc4891d6ab12174ac5 | |
| parent | e73d2479dd03132a1147c013426ea8e88c10d2ff (diff) | |
| download | gcc-3a4efce7c246b190ef35a8ce1f108f572274521f.zip gcc-3a4efce7c246b190ef35a8ce1f108f572274521f.tar.gz gcc-3a4efce7c246b190ef35a8ce1f108f572274521f.tar.bz2 | |
re PR preprocessor/55715 (bogus overflow warning for #if A-B when A<0 & B==minimum integer)
PR preprocessor/55715
libcpp:
* expr.c (num_binary_op): Implement subtraction directly rather
than with negation and falling through into addition case.
gcc/testsuite:
* gcc.dg/cpp/expr-overflow-1.c: New test.
From-SVN: r205846
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/cpp/expr-overflow-1.c | 44 | ||||
| -rw-r--r-- | libcpp/ChangeLog | 6 | ||||
| -rw-r--r-- | libcpp/expr.c | 17 |
4 files changed, 71 insertions, 1 deletions
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 27c8168..7945eac 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-12-09 Joseph Myers <joseph@codesourcery.com> + + PR preprocessor/55715 + * gcc.dg/cpp/expr-overflow-1.c: New test. + 2013-12-10 Tobias Burnus <burnus@net-b.de> PR fortran/59428 diff --git a/gcc/testsuite/gcc.dg/cpp/expr-overflow-1.c b/gcc/testsuite/gcc.dg/cpp/expr-overflow-1.c new file mode 100644 index 0000000..8a67aaa --- /dev/null +++ b/gcc/testsuite/gcc.dg/cpp/expr-overflow-1.c @@ -0,0 +1,44 @@ +/* Test overflow in preprocessor arithmetic. PR 55715. */ +/* { dg-do preprocess } */ +/* { dg-options "-std=c99" } */ + +#include <stdint.h> + +#if -1 - INTMAX_MIN +#endif + +#if 0 - INTMAX_MIN /* { dg-warning "overflow" } */ +#endif + +#if 1 * INTMAX_MIN +#endif + +#if -1 * INTMAX_MIN /* { dg-warning "overflow" } */ +#endif + +#if 0 * INTMAX_MIN +#endif + +#if -INTMAX_MIN /* { dg-warning "overflow" } */ +#endif + +#if +INTMAX_MIN +#endif + +#if INTMAX_MIN / 1 +#endif + +#if INTMAX_MIN / -1 /* { dg-warning "overflow" } */ +#endif + +#if UINTMAX_MAX * UINTMAX_MAX +#endif + +#if UINTMAX_MAX / -1 +#endif + +#if UINTMAX_MAX + INTMAX_MAX +#endif + +#if UINTMAX_MAX - INTMAX_MIN +#endif diff --git a/libcpp/ChangeLog b/libcpp/ChangeLog index c3391b4..4a06d0c 100644 --- a/libcpp/ChangeLog +++ b/libcpp/ChangeLog @@ -1,3 +1,9 @@ +2013-12-09 Joseph Myers <joseph@codesourcery.com> + + PR preprocessor/55715 + * expr.c (num_binary_op): Implement subtraction directly rather + than with negation and falling through into addition case. + 2013-11-18 Bill Schmidt <wschmidt@linux.vnet.ibm.com> * lex.c (search_line_fast): Correct for little endian. diff --git a/libcpp/expr.c b/libcpp/expr.c index c009807..1e17b00 100644 --- a/libcpp/expr.c +++ b/libcpp/expr.c @@ -1836,7 +1836,22 @@ num_binary_op (cpp_reader *pfile, cpp_num lhs, cpp_num rhs, enum cpp_ttype op) /* Arithmetic. */ case CPP_MINUS: - rhs = num_negate (rhs, precision); + result.low = lhs.low - rhs.low; + result.high = lhs.high - rhs.high; + if (result.low > lhs.low) + result.high--; + result.unsignedp = lhs.unsignedp || rhs.unsignedp; + result.overflow = false; + + result = num_trim (result, precision); + if (!result.unsignedp) + { + bool lhsp = num_positive (lhs, precision); + result.overflow = (lhsp != num_positive (rhs, precision) + && lhsp != num_positive (result, precision)); + } + return result; + case CPP_PLUS: result.low = lhs.low + rhs.low; result.high = lhs.high + rhs.high; |